dd-trace-java icon indicating copy to clipboard operation
dd-trace-java copied to clipboard

[jmxfetch] `run()` will be non-static for App

Open truthbk opened this issue 4 years ago • 2 comments

This is a very small PR to address a small change we expect to implement in the JMXFetch lib, by which the App.run() method will no longer be static. It is currently a nasty piece of code we have in JMXFetch we would like to get rid of. It should be of minor impact as it still seems very self contained within the tracer use of the lib.

truthbk avatar Nov 09 '21 18:11 truthbk

note: I can see the tests failing until we actually release the new JMXFetch version.

truthbk avatar Nov 09 '21 18:11 truthbk

This is the PR on the jmxfetch side: https://github.com/DataDog/jmxfetch/pull/376

truthbk avatar Nov 09 '21 19:11 truthbk

Closing as stale, this change was applied in #3236

mcculls avatar Nov 16 '23 18:11 mcculls