dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

[Profiler] Use ringbuffer with timer create

Open gleocadie opened this issue 6 months ago • 3 comments

Summary of changes

https://datadoghq.atlassian.net/browse/PROF-11985

Reason for change

Implementation details

Test coverage

Other details

gleocadie avatar Jun 05 '25 11:06 gleocadie

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7066) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 70, 73
     .   : milestone, 72,

    section Baseline
    This PR (7066) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (68ms)  : 65, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (1,042ms)  : 1019, 1064
     .   : milestone, 1042,
    master - mean (1,042ms)  : 1019, 1065
     .   : milestone, 1042,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7066) - mean (107ms)  : 105, 108
     .   : milestone, 107,
    master - mean (106ms)  : 105, 108
     .   : milestone, 106,

    section Baseline
    This PR (7066) - mean (105ms)  : 103, 108
     .   : milestone, 105,
    master - mean (105ms)  : 103, 107
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (725ms)  : 707, 744
     .   : milestone, 725,
    master - mean (726ms)  : 712, 739
     .   : milestone, 726,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7066) - mean (94ms)  : 93, 96
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7066) - mean (94ms)  : 91, 97
     .   : milestone, 94,
    master - mean (93ms)  : 92, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (692ms)  : 666, 718
     .   : milestone, 692,
    master - mean (685ms)  : 664, 705
     .   : milestone, 685,

gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7066) - mean (93ms)  : 91, 94
     .   : milestone, 93,
    master - mean (95ms)  : 90, 99
     .   : milestone, 95,

    section Baseline
    This PR (7066) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (98ms)  : 83, 112
     .   : milestone, 98,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (623ms)  : 600, 645
     .   : milestone, 623,
    master - mean (629ms)  : 610, 648
     .   : milestone, 629,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7066) - mean (192ms)  : 185, 199
     .   : milestone, 192,
    master - mean (210ms)  : 198, 223
     .   : milestone, 210,

    section Baseline
    This PR (7066) - mean (189ms)  : 181, 198
     .   : milestone, 189,
    master - mean (208ms)  : 195, 221
     .   : milestone, 208,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (1,155ms)  : 1120, 1190
     .   : milestone, 1155,
    master - mean (1,407ms)  : 1305, 1509
     .   : milestone, 1407,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7066) - mean (274ms)  : 267, 281
     .   : milestone, 274,
    master - mean (277ms)  : 257, 297
     .   : milestone, 277,

    section Baseline
    This PR (7066) - mean (271ms)  : 262, 280
     .   : milestone, 271,
    master - mean (305ms)  : 289, 321
     .   : milestone, 305,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (914ms)  : 890, 938
     .   : milestone, 914,
    master - mean (917ms)  : 889, 945
     .   : milestone, 917,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7066) - mean (267ms)  : 254, 280
     .   : milestone, 267,
    master - mean (269ms)  : 263, 276
     .   : milestone, 269,

    section Baseline
    This PR (7066) - mean (265ms)  : 255, 275
     .   : milestone, 265,
    master - mean (268ms)  : 257, 278
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (903ms)  : 879, 928
     .   : milestone, 903,
    master - mean (902ms)  : 877, 927
     .   : milestone, 902,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7066) - mean (265ms)  : 256, 275
     .   : milestone, 265,
    master - mean (266ms)  : 257, 276
     .   : milestone, 266,

    section Baseline
    This PR (7066) - mean (264ms)  : 253, 275
     .   : milestone, 264,
    master - mean (266ms)  : 258, 274
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (7066) - mean (816ms)  : 777, 855
     .   : milestone, 816,
    master - mean (821ms)  : 788, 854
     .   : milestone, 821,

andrewlock avatar Jun 05 '25 11:06 andrewlock

Datadog Report

All test runs 26a5d67 :link:

:white_check_mark: 2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 0 250664 2865 17h 6m 47.12s Link
exploration_tests 0 0 0 22085 3 2m 27.4s Link

Benchmarks

Benchmarks Report for benchmark platform :snail:

Benchmarks for #7066 compared to master:

  • 7 benchmarks are slower, with geometric mean 1.808
  • 44 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 6.05 KB -36 B -0.59%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.72 KB -36 B -0.63%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.5 KB -74 B -1.33%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7066 StartStopWithChild net6.0 10.7μs 55.7ns 284ns 0 0 0 5.5 KB
#7066 StartStopWithChild netcoreapp3.1 13.7μs 70.3ns 337ns 0 0 0 5.72 KB
#7066 StartStopWithChild net472 22.2μs 122ns 690ns 0.952 0.212 0 6.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7066 WriteAndFlushEnrichedTraces net6.0 950μs 307ns 1.19μs 0 0 0 2.71 KB
#7066 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 55ns 206ns 0 0 0 2.7 KB
#7066 WriteAndFlushEnrichedTraces net472 1.19ms 34ns 123ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 247.98 KB 11.62 KB 4.92%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 251.51 KB 11.64 KB 4.85%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7066 AllCycleSimpleBody net6.0 338μs 1.63μs 6.51μs 0 0 0 197.61 KB
#7066 AllCycleSimpleBody netcoreapp3.1 498μs 2.27μs 8.5μs 0 0 0 205.37 KB
#7066 AllCycleSimpleBody net472 451μs 104ns 388ns 37.9 2.23 0 247.98 KB
#7066 AllCycleMoreComplexBody net6.0 342μs 1.47μs 5.5μs 0 0 0 201.12 KB
#7066 AllCycleMoreComplexBody netcoreapp3.1 509μs 2.16μs 8.35μs 0 0 0 208.78 KB
#7066 AllCycleMoreComplexBody net472 460μs 127ns 494ns 37.9 2.23 0 251.51 KB
#7066 ObjectExtractorSimpleBody net6.0 330ns 0.139ns 0.52ns 0 0 0 280 B
#7066 ObjectExtractorSimpleBody netcoreapp3.1 407ns 0.457ns 1.77ns 0 0 0 272 B
#7066 ObjectExtractorSimpleBody net472 304ns 0.0811ns 0.314ns 0.0445 0 0 281 B
#7066 ObjectExtractorMoreComplexBody net6.0 6.39μs 2.7ns 10.5ns 0 0 0 3.78 KB
#7066 ObjectExtractorMoreComplexBody netcoreapp3.1 7.8μs 36.6ns 151ns 0 0 0 3.69 KB
#7066 ObjectExtractorMoreComplexBody net472 6.76μs 5.09ns 19.7ns 0.576 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7066 EncodeArgs net6.0 76.9μs 315ns 1.18μs 0 0 0 32.4 KB
#7066 EncodeArgs netcoreapp3.1 98.3μs 26.1ns 97.6ns 0 0 0 32.4 KB
#7066 EncodeArgs net472 109μs 8.88ns 30.8ns 4.92 0 0 32.5 KB
#7066 EncodeLegacyArgs net6.0 147μs 23.4ns 90.6ns 0 0 0 2.15 KB
#7066 EncodeLegacyArgs netcoreapp3.1 198μs 235ns 848ns 0 0 0 2.14 KB
#7066 EncodeLegacyArgs net472 264μs 55.6ns 208ns 0 0 0 2.17 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #7066

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 3.643 198,578.46 723,417.04
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 2.919 293,157.49 855,807.71
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net6.0 1.625 181,119.78 294,409.74
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net472 1.498 206,733.04 309,714.94
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑net6.0 1.441 271,505.69 391,144.56
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑net472 1.389 306,857.62 426,303.23

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7066 RunWafRealisticBenchmark net6.0 391μs 56.9ns 205ns 0 0 0 4.55 KB
#7066 RunWafRealisticBenchmark netcoreapp3.1 799μs 16.1μs 149μs 0 0 0 4.48 KB
#7066 RunWafRealisticBenchmark net472 426μs 53.4ns 207ns 0 0 0 4.66 KB
#7066 RunWafRealisticBenchmarkWithAttack net6.0 294μs 41.5ns 155ns 0 0 0 2.24 KB
#7066 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 716μs 4.86μs 48.6μs 0 0 0 2.22 KB
#7066 RunWafRealisticBenchmarkWithAttack net472 310μs 44.6ns 173ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7066 SendRequest net6.0 61.7μs 37.8ns 146ns 0 0 0 14.52 KB
#7066 SendRequest netcoreapp3.1 70.3μs 46.8ns 175ns 0 0 0 17.42 KB
#7066 SendRequest net472 0.00588ns 0.00215ns 0.00833ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
#7066 OriginalCharSlice net6.0 1.96ms 2.13μs 8.26μs 0 0 0 640.01 KB
#7066 OriginalCharSlice netcoreapp3.1 2.13ms 11μs 51.4μs 0 0 0 640 KB
#7066 OriginalCharSlice net472 2.76ms 640ns 2.48μs 100 0 0 641.95 KB
#7066 OptimizedCharSlice net6.0 1.47ms 337ns 1.31μs 0 0 0 7 B
#7066 OptimizedCharSlice netcoreapp3.1 1.65ms 296ns 1.15μs 0 0 0 1 B
#7066 OptimizedCharSlice net472 1.98ms 536ns 2.07μs 0 0 0 73 B
#7066 OptimizedCharSliceWithPool net6.0 800μs 34.6ns 134ns 0 0 0 3 B
#7066 OptimizedCharSliceWithPool netcoreapp3.1 896μs 54.5ns 211ns 0 0 0 0 b
#7066 OptimizedCharSliceWithPool net472 1.13ms 63.9ns 239ns 0 0 0 47 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.75 KB 56.18 KB 429 B 0.77%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7066 WriteAndFlushEnrichedTraces net6.0 630μs 3.15μs 17.6μs 0 0 0 41.75 KB
#7066 WriteAndFlushEnrichedTraces netcoreapp3.1 707μs 4.11μs 36.5μs 0 0 0 41.83 KB
#7066 WriteAndFlushEnrichedTraces net472 949μs 3.34μs 12.5μs 4.81 0 0 56.18 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7066 ExecuteNonQuery net6.0 1.87μs 9.65ns 49.2ns 0 0 0 1.02 KB
#7066 ExecuteNonQuery netcoreapp3.1 2.54μs 9.67ns 37.5ns 0 0 0 1.02 KB
#7066 ExecuteNonQuery net472 2.96μs 2.79ns 9.66ns 0.146 0.0146 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -7 B -0.64%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7066 CallElasticsearch net6.0 1.69μs 8.56ns 38.3ns 0 0 0 1.03 KB
#7066 CallElasticsearch netcoreapp3.1 2.4μs 10.4ns 40.2ns 0 0 0 1.03 KB
#7066 CallElasticsearch net472 3.65μs 3.38ns 13.1ns 0.163 0 0 1.04 KB
#7066 CallElasticsearchAsync net6.0 1.84μs 4.41ns 16.5ns 0 0 0 1.01 KB
#7066 CallElasticsearchAsync netcoreapp3.1 2.53μs 4.8ns 18.6ns 0 0 0 1.08 KB
#7066 CallElasticsearchAsync net472 3.78μs 5.6ns 21.7ns 0.17 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7066 ExecuteAsync net6.0 1.84μs 3.53ns 13.7ns 0 0 0 952 B
#7066 ExecuteAsync netcoreapp3.1 2.35μs 11.1ns 43.1ns 0 0 0 952 B
#7066 ExecuteAsync net472 2.62μs 4.22ns 16.3ns 0.144 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7066 SendAsync net6.0 6.95μs 16ns 60ns 0 0 0 2.36 KB
#7066 SendAsync netcoreapp3.1 8.42μs 27.7ns 107ns 0 0 0 2.9 KB
#7066 SendAsync net472 12.3μs 14.6ns 56.7ns 0.496 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #7066

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.219 413,700.00 504,250.00

More allocations :warning: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.83 KB 45.13 KB 1.3 KB 2.96%

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 258.62 KB -1.34 KB -0.52%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.8 KB -7.92 KB -2.76%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.93 KB 258.55 KB -16.38 KB -5.96%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7066 StringConcatBenchmark net6.0 48.7μs 284ns 2.32μs 0 0 0 45.13 KB
#7066 StringConcatBenchmark netcoreapp3.1 50.3μs 296ns 2.74μs 0 0 0 42.76 KB
#7066 StringConcatBenchmark net472 57μs 189ns 682ns 0 0 0 57.34 KB
#7066 StringConcatAspectBenchmark net6.0 453μs 1.64μs 6.14μs 0 0 0 258.62 KB
#7066 StringConcatAspectBenchmark netcoreapp3.1 506μs 2.48μs 9.92μs 0 0 0 258.55 KB
#7066 StringConcatAspectBenchmark net472 406μs 2μs 8.72μs 0 0 0 278.8 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7066 EnrichedLog net6.0 2.59μs 11.1ns 42.9ns 0 0 0 1.7 KB
#7066 EnrichedLog netcoreapp3.1 3.49μs 14.9ns 57.6ns 0 0 0 1.7 KB
#7066 EnrichedLog net472 3.81μs 4.6ns 17.8ns 0.247 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.52 KB -55 B -1.20%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -56 B -1.28%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7066 EnrichedLog net6.0 123μs 65.2ns 235ns 0 0 0 4.31 KB
#7066 EnrichedLog netcoreapp3.1 127μs 77ns 288ns 0 0 0 4.31 KB
#7066 EnrichedLog net472 168μs 179ns 619ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7066 EnrichedLog net6.0 5.02μs 17.7ns 68.5ns 0 0 0 2.26 KB
#7066 EnrichedLog netcoreapp3.1 6.65μs 15.3ns 59.2ns 0 0 0 2.26 KB
#7066 EnrichedLog net472 7.57μs 6.49ns 25.1ns 0.303 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7066 SendReceive net6.0 1.98μs 9.12ns 35.3ns 0 0 0 1.2 KB
#7066 SendReceive netcoreapp3.1 2.61μs 11.9ns 47.5ns 0 0 0 1.2 KB
#7066 SendReceive net472 3.33μs 1.22ns 4.39ns 0.184 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7066 EnrichedLog net6.0 4.33μs 3.42ns 12.8ns 0 0 0 1.58 KB
#7066 EnrichedLog netcoreapp3.1 5.54μs 14.9ns 57.8ns 0 0 0 1.63 KB
#7066 EnrichedLog net472 6.64μs 8.88ns 34.4ns 0.299 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7066 StartFinishSpan net6.0 751ns 3.63ns 14.5ns 0 0 0 576 B
#7066 StartFinishSpan netcoreapp3.1 947ns 5.15ns 28.7ns 0 0 0 576 B
#7066 StartFinishSpan net472 897ns 0.528ns 2.04ns 0.0902 0 0 578 B
#7066 StartFinishScope net6.0 893ns 4.61ns 20.6ns 0 0 0 696 B
#7066 StartFinishScope netcoreapp3.1 1.2μs 5.92ns 23.7ns 0 0 0 696 B
#7066 StartFinishScope net472 1.08μs 0.271ns 1.05ns 0.103 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7066 RunOnMethodBegin net6.0 1.1μs 0.615ns 2.38ns 0 0 0 696 B
#7066 RunOnMethodBegin netcoreapp3.1 1.4μs 6.87ns 28.3ns 0 0 0 696 B
#7066 RunOnMethodBegin net472 1.43μs 0.458ns 1.71ns 0.101 0 0 658 B

pr-commenter[bot] avatar Jun 05 '25 12:06 pr-commenter[bot]

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 03653de | Was this helpful? Give us feedback!