dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Gleocadie/bump libdatadog v18.1

Open gleocadie opened this issue 6 months ago • 2 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

gleocadie avatar May 30 '25 17:05 gleocadie

Datadog Report

All test runs 63e7a26 :link:

:x: 2 Total Test Services: 1 Failed, 1 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 10 0 0 243713 2841 17h 10m 26.72s Link
exploration_tests 0 0 0 22085 3 2m 16.54s Link

:x: Failed Tests (10)

This report shows up to 5 failed tests.

  • GenerateDumpIfDbgRequested - Datadog.Profiler.IntegrationTests.LinuxOnly.WrapperLibraryTest - Details

    Expand for error
    xpected processHelper.ErrorOutput "Unhandled exception. System.BadImageFormatException: Task failed successfully.
      at Samples.ExceptionGenerator.Program.Main(String[] args) in /project/profiler/src/Demos/Samples.ExceptionGenerator/Program.cs:line 56
     to contain "Unhandled exception. System.InvalidOperationException: Task failed successfully".
    
  • GenerateDumpIfDbgRequested - Datadog.Profiler.IntegrationTests.LinuxOnly.WrapperLibraryTest - Details

    Expand for error
    xpected processHelper.ErrorOutput "Unhandled exception. System.BadImageFormatException: Task failed successfully.
      at Samples.ExceptionGenerator.Program.Main(String[] args) in /project/profiler/src/Demos/Samples.ExceptionGenerator/Program.cs:line 99
     to contain "Unhandled exception. System.InvalidOperationException: Task failed successfully".
    
  • GenerateDumpIfDbgRequested - Datadog.Profiler.IntegrationTests.LinuxOnly.WrapperLibraryTest - Details

    Expand for error
    xpected processHelper.ErrorOutput "Unhandled exception. System.BadImageFormatException: Task failed successfully.
      at Samples.ExceptionGenerator.Program.Main(String[] args) in /project/profiler/src/Demos/Samples.ExceptionGenerator/Program.cs:line 99
     to contain "Unhandled exception. System.InvalidOperationException: Task failed successfully".
    
  • GenerateDumpIfDbgRequested - Datadog.Profiler.IntegrationTests.LinuxOnly.WrapperLibraryTest - Details

    Expand for error
    xpected processHelper.ErrorOutput "Unhandled exception. System.BadImageFormatException: Task failed successfully.
      at Samples.ExceptionGenerator.Program.Main(String[] args) in /project/profiler/src/Demos/Samples.ExceptionGenerator/Program.cs:line 99
     to contain "Unhandled exception. System.InvalidOperationException: Task failed successfully".
    
  • GenerateDumpIfDbgRequested - Datadog.Profiler.IntegrationTests.LinuxOnly.WrapperLibraryTest - Details

    Expand for error
    xpected processHelper.ErrorOutput "Unhandled exception. System.BadImageFormatException: Task failed successfully.
      at Samples.ExceptionGenerator.Program.Main(String[] args) in /project/profiler/src/Demos/Samples.ExceptionGenerator/Program.cs:line 99
     to contain "Unhandled exception. System.InvalidOperationException: Task failed successfully".
    

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7035) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (69ms)  : 63, 74
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7035) - mean (1,007ms)  : 987, 1027
     .   : milestone, 1007,
    master - mean (1,009ms)  : 986, 1033
     .   : milestone, 1009,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7035) - mean (102ms)  : 100, 103
     .   : milestone, 102,
    master - mean (103ms)  : 100, 105
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (7035) - mean (690ms)  : 672, 709
     .   : milestone, 690,
    master - mean (698ms)  : 682, 713
     .   : milestone, 698,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7035) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7035) - mean (649ms)  : 634, 664
     .   : milestone, 649,
    master - mean (656ms)  : 633, 678
     .   : milestone, 656,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7035) - mean (190ms)  : 187, 194
     .   : milestone, 190,
    master - mean (190ms)  : 181, 200
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7035) - mean (1,111ms)  : 1091, 1131
     .   : milestone, 1111,
    master - mean (1,111ms)  : 1079, 1142
     .   : milestone, 1111,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7035) - mean (269ms)  : 265, 272
     .   : milestone, 269,
    master - mean (268ms)  : 265, 271
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (7035) - mean (881ms)  : 843, 919
     .   : milestone, 881,
    master - mean (879ms)  : 851, 907
     .   : milestone, 879,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7035) - mean (261ms)  : 257, 264
     .   : milestone, 261,
    master - mean (261ms)  : 257, 264
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (7035) - mean (864ms)  : 837, 891
     .   : milestone, 864,
    master - mean (869ms)  : 834, 904
     .   : milestone, 869,

andrewlock avatar May 30 '25 18:05 andrewlock

Currently on V20, so closing as no longer relevant.

bouwkast avatar Oct 03 '25 22:10 bouwkast