dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

[Profiler] Add ringbuffer

Open gleocadie opened this issue 6 months ago • 3 comments

Summary of changes

Add a ring buffer implementation (taken from https://github.com/DataDog/ddprof and adjusted to our needs a bit)

Reason for change

This PR is the beginning to fix the timer_create issue (crash the process if a timer ticks while the thread is being destroyed)

Implementation details

Test coverage

  • [x] Unit tests
  • [x] Add multithread tests + TSAN run in CI

Other details

gleocadie avatar May 28 '25 12:05 gleocadie

Datadog Report

All test runs f972150 :link:

:white_check_mark: 2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 0 231007 2787 17h 7m 57.47s Link
exploration_tests 0 0 0 22085 3 2m 10.61s Link

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7025) - mean (80ms)  : 77, 83
     .   : milestone, 80,
    master - mean (79ms)  : 76, 83
     .   : milestone, 79,

    section Baseline
    This PR (7025) - mean (76ms)  : 71, 81
     .   : milestone, 76,
    master - mean (76ms)  : 70, 82
     .   : milestone, 76,

    section CallTarget+Inlining+NGEN
    This PR (7025) - mean (1,093ms)  : 1059, 1126
     .   : milestone, 1093,
    master - mean (1,085ms)  : 1058, 1111
     .   : milestone, 1085,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7025) - mean (120ms)  : 115, 125
     .   : milestone, 120,
    master - mean (119ms)  : 114, 125
     .   : milestone, 119,

    section Baseline
    This PR (7025) - mean (119ms)  : 113, 124
     .   : milestone, 119,
    master - mean (119ms)  : 114, 124
     .   : milestone, 119,

    section CallTarget+Inlining+NGEN
    This PR (7025) - mean (762ms)  : 744, 781
     .   : milestone, 762,
    master - mean (763ms)  : 741, 784
     .   : milestone, 763,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7025) - mean (107ms)  : 103, 111
     .   : milestone, 107,
    master - mean (106ms)  : 101, 111
     .   : milestone, 106,

    section Baseline
    This PR (7025) - mean (106ms)  : 101, 110
     .   : milestone, 106,
    master - mean (105ms)  : 100, 110
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7025) - mean (728ms)  : 701, 755
     .   : milestone, 728,
    master - mean (725ms)  : 704, 746
     .   : milestone, 725,

gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7025) - mean (106ms)  : 101, 112
     .   : milestone, 106,
    master - mean (105ms)  : 101, 110
     .   : milestone, 105,

    section Baseline
    This PR (7025) - mean (105ms)  : 100, 109
     .   : milestone, 105,
    master - mean (104ms)  : 99, 108
     .   : milestone, 104,

    section CallTarget+Inlining+NGEN
    This PR (7025) - mean (659ms)  : 626, 691
     .   : milestone, 659,
    master - mean (657ms)  : 634, 679
     .   : milestone, 657,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7025) - mean (215ms)  : 207, 223
     .   : milestone, 215,
    master - mean (215ms)  : 208, 221
     .   : milestone, 215,

    section Baseline
    This PR (7025) - mean (210ms)  : 202, 219
     .   : milestone, 210,
    master - mean (211ms)  : 203, 219
     .   : milestone, 211,

    section CallTarget+Inlining+NGEN
    This PR (7025) - mean (1,222ms)  : 1189, 1254
     .   : milestone, 1222,
    master - mean (1,226ms)  : 1188, 1264
     .   : milestone, 1226,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7025) - mean (306ms)  : 297, 316
     .   : milestone, 306,
    master - mean (305ms)  : 295, 314
     .   : milestone, 305,

    section Baseline
    This PR (7025) - mean (305ms)  : 295, 315
     .   : milestone, 305,
    master - mean (303ms)  : 295, 312
     .   : milestone, 303,

    section CallTarget+Inlining+NGEN
    This PR (7025) - mean (987ms)  : 954, 1019
     .   : milestone, 987,
    master - mean (984ms)  : 944, 1025
     .   : milestone, 984,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7025) - mean (299ms)  : 292, 307
     .   : milestone, 299,
    master - mean (299ms)  : 288, 310
     .   : milestone, 299,

    section Baseline
    This PR (7025) - mean (298ms)  : 291, 306
     .   : milestone, 298,
    master - mean (300ms)  : 291, 308
     .   : milestone, 300,

    section CallTarget+Inlining+NGEN
    This PR (7025) - mean (973ms)  : 943, 1002
     .   : milestone, 973,
    master - mean (972ms)  : 940, 1004
     .   : milestone, 972,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7025) - mean (300ms)  : 290, 310
     .   : milestone, 300,
    master - mean (299ms)  : 288, 309
     .   : milestone, 299,

    section Baseline
    This PR (7025) - mean (297ms)  : 288, 306
     .   : milestone, 297,
    master - mean (298ms)  : 289, 307
     .   : milestone, 298,

    section CallTarget+Inlining+NGEN
    This PR (7025) - mean (881ms)  : 819, 943
     .   : milestone, 881,
    master - mean (873ms)  : 821, 924
     .   : milestone, 873,

andrewlock avatar May 28 '25 12:05 andrewlock

Benchmarks

Benchmarks Report for benchmark platform :snail:

Benchmarks for #7025 compared to master:

  • 8 benchmarks are slower, with geometric mean 1.574
  • 43 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.69 KB -65 B -1.13%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.5 KB -75 B -1.34%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 6 KB -92 B -1.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7025 StartStopWithChild net6.0 10.5μs 57.4ns 354ns 0 0 0 5.5 KB
#7025 StartStopWithChild netcoreapp3.1 13.2μs 68.5ns 329ns 0 0 0 5.69 KB
#7025 StartStopWithChild net472 22.7μs 127ns 824ns 0.852 0.319 0 6 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7025 WriteAndFlushEnrichedTraces net6.0 941μs 86.4ns 335ns 0 0 0 2.71 KB
#7025 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 120ns 448ns 0 0 0 2.7 KB
#7025 WriteAndFlushEnrichedTraces net472 1.21ms 460ns 1.78μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 239.66 KB 3.3 KB 1.40%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 243.17 KB 3.3 KB 1.38%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7025 AllCycleSimpleBody net6.0 332μs 762ns 2.95μs 0 0 0 197.61 KB
#7025 AllCycleSimpleBody netcoreapp3.1 488μs 1.11μs 4.29μs 0 0 0 205.37 KB
#7025 AllCycleSimpleBody net472 442μs 259ns 1μs 36.6 2.16 0 239.66 KB
#7025 AllCycleMoreComplexBody net6.0 339μs 237ns 919ns 0 0 0 201.12 KB
#7025 AllCycleMoreComplexBody netcoreapp3.1 515μs 2.4μs 9.3μs 0 0 0 208.78 KB
#7025 AllCycleMoreComplexBody net472 449μs 164ns 614ns 37.9 2.23 0 243.17 KB
#7025 ObjectExtractorSimpleBody net6.0 311ns 1.55ns 6.92ns 0 0 0 280 B
#7025 ObjectExtractorSimpleBody netcoreapp3.1 411ns 2.03ns 8.37ns 0 0 0 272 B
#7025 ObjectExtractorSimpleBody net472 308ns 0.0406ns 0.157ns 0.0432 0 0 281 B
#7025 ObjectExtractorMoreComplexBody net6.0 6.31μs 28.5ns 110ns 0 0 0 3.78 KB
#7025 ObjectExtractorMoreComplexBody netcoreapp3.1 7.82μs 19.2ns 74.4ns 0 0 0 3.69 KB
#7025 ObjectExtractorMoreComplexBody net472 6.83μs 3.18ns 12.3ns 0.581 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.14 KB -12 B -0.56%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7025 EncodeArgs net6.0 79.6μs 68.4ns 246ns 0 0 0 32.4 KB
#7025 EncodeArgs netcoreapp3.1 97.5μs 231ns 896ns 0 0 0 32.4 KB
#7025 EncodeArgs net472 109μs 57.6ns 223ns 4.95 0 0 32.51 KB
#7025 EncodeLegacyArgs net6.0 145μs 84.5ns 327ns 0 0 0 2.14 KB
#7025 EncodeLegacyArgs netcoreapp3.1 196μs 99ns 383ns 0 0 0 2.14 KB
#7025 EncodeLegacyArgs net472 263μs 18.7ns 70.1ns 0 0 0 2.17 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #7025

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 3.686 198,578.46 731,994.42
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net6.0 1.695 181,119.78 307,071.31
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net472 1.493 206,733.04 308,677.29
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑net6.0 1.454 271,505.69 394,736.39
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 1.403 293,157.49 411,390.83
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑net472 1.394 306,857.62 427,702.08

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7025 RunWafRealisticBenchmark net6.0 395μs 106ns 398ns 0 0 0 4.55 KB
#7025 RunWafRealisticBenchmark netcoreapp3.1 412μs 248ns 961ns 0 0 0 4.48 KB
#7025 RunWafRealisticBenchmark net472 428μs 55.8ns 216ns 0 0 0 4.66 KB
#7025 RunWafRealisticBenchmarkWithAttack net6.0 309μs 733ns 2.84μs 0 0 0 2.24 KB
#7025 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 689μs 9.79μs 97.9μs 0 0 0 2.22 KB
#7025 RunWafRealisticBenchmarkWithAttack net472 309μs 32.4ns 126ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7025 SendRequest net6.0 61.1μs 106ns 397ns 0 0 0 14.52 KB
#7025 SendRequest netcoreapp3.1 71.9μs 171ns 664ns 0 0 0 17.42 KB
#7025 SendRequest net472 0.0168ns 0.00164ns 0.00637ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
#7025 OriginalCharSlice net6.0 1.95ms 703ns 2.63μs 0 0 0 640.01 KB
#7025 OriginalCharSlice netcoreapp3.1 2.15ms 10.4μs 42.9μs 0 0 0 640 KB
#7025 OriginalCharSlice net472 2.61ms 266ns 1.03μs 100 0 0 641.95 KB
#7025 OptimizedCharSlice net6.0 1.36ms 333ns 1.29μs 0 0 0 4 B
#7025 OptimizedCharSlice netcoreapp3.1 1.7ms 81.3ns 315ns 0 0 0 1 B
#7025 OptimizedCharSlice net472 1.99ms 461ns 1.78μs 0 0 0 73 B
#7025 OptimizedCharSliceWithPool net6.0 804μs 43.2ns 167ns 0 0 0 4 B
#7025 OptimizedCharSliceWithPool netcoreapp3.1 808μs 44.8ns 162ns 0 0 0 0 b
#7025 OptimizedCharSliceWithPool net472 1.18ms 54.1ns 209ns 0 0 0 47 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #7025

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.188 631,437.50 750,439.96

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7025 WriteAndFlushEnrichedTraces net6.0 656μs 1.69μs 6.56μs 0 0 0 41.71 KB
#7025 WriteAndFlushEnrichedTraces netcoreapp3.1 755μs 2.81μs 10.9μs 0 0 0 41.77 KB
#7025 WriteAndFlushEnrichedTraces net472 918μs 2.1μs 7.28μs 4.46 0 0 55.95 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7025 ExecuteNonQuery net6.0 1.91μs 8.55ns 33.1ns 0 0 0 1.02 KB
#7025 ExecuteNonQuery netcoreapp3.1 2.54μs 6.34ns 23.7ns 0 0 0 1.02 KB
#7025 ExecuteNonQuery net472 2.67μs 3.23ns 12.5ns 0.144 0.0131 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7025 CallElasticsearch net6.0 1.72μs 9.22ns 46.1ns 0 0 0 1.03 KB
#7025 CallElasticsearch netcoreapp3.1 2.29μs 7.02ns 26.2ns 0 0 0 1.03 KB
#7025 CallElasticsearch net472 3.56μs 1.52ns 5.69ns 0.16 0 0 1.04 KB
#7025 CallElasticsearchAsync net6.0 1.77μs 7.26ns 28.1ns 0 0 0 1.01 KB
#7025 CallElasticsearchAsync netcoreapp3.1 2.61μs 5.07ns 19.6ns 0 0 0 1.08 KB
#7025 CallElasticsearchAsync net472 3.93μs 3.16ns 12.2ns 0.174 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7025 ExecuteAsync net6.0 1.86μs 8.87ns 35.5ns 0 0 0 952 B
#7025 ExecuteAsync netcoreapp3.1 2.4μs 9.9ns 37ns 0 0 0 952 B
#7025 ExecuteAsync net472 2.65μs 2.7ns 10.5ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7025 SendAsync net6.0 6.88μs 9.94ns 37.2ns 0 0 0 2.36 KB
#7025 SendAsync netcoreapp3.1 8.53μs 6.85ns 26.5ns 0 0 0 2.9 KB
#7025 SendAsync net472 12.3μs 13.2ns 50.9ns 0.496 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #7025

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.196 413,700.00 494,600.00

More allocations :warning: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 278.34 KB 18.38 KB 7.07%

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.93 KB 257.82 KB -17.1 KB -6.22%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7025 StringConcatBenchmark net6.0 43.6μs 236ns 1.34μs 0 0 0 43.78 KB
#7025 StringConcatBenchmark netcoreapp3.1 50.4μs 589ns 5.71μs 0 0 0 42.85 KB
#7025 StringConcatBenchmark net472 57.1μs 250ns 969ns 0 0 0 57.34 KB
#7025 StringConcatAspectBenchmark net6.0 495μs 1.25μs 4.5μs 0 0 0 278.34 KB
#7025 StringConcatAspectBenchmark netcoreapp3.1 496μs 2.43μs 9.72μs 0 0 0 257.82 KB
#7025 StringConcatAspectBenchmark net472 400μs 2.28μs 16.7μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7025 EnrichedLog net6.0 2.61μs 13.1ns 58.6ns 0 0 0 1.7 KB
#7025 EnrichedLog netcoreapp3.1 3.4μs 16.8ns 69.4ns 0 0 0 1.7 KB
#7025 EnrichedLog net472 3.86μs 3.04ns 11.8ns 0.251 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.52 KB -55 B -1.20%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -56 B -1.28%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7025 EnrichedLog net6.0 122μs 59.4ns 230ns 0 0 0 4.31 KB
#7025 EnrichedLog netcoreapp3.1 127μs 154ns 575ns 0 0 0 4.31 KB
#7025 EnrichedLog net472 167μs 178ns 688ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7025 EnrichedLog net6.0 4.9μs 16.6ns 64.4ns 0 0 0 2.26 KB
#7025 EnrichedLog netcoreapp3.1 6.7μs 19.1ns 74ns 0 0 0 2.26 KB
#7025 EnrichedLog net472 7.6μs 10.8ns 41.8ns 0.302 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7025 SendReceive net6.0 2.02μs 1.14ns 4.25ns 0 0 0 1.2 KB
#7025 SendReceive netcoreapp3.1 2.65μs 10.7ns 41.6ns 0 0 0 1.2 KB
#7025 SendReceive net472 3.12μs 2.07ns 7.74ns 0.186 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7025 EnrichedLog net6.0 4.28μs 6.41ns 22.2ns 0 0 0 1.58 KB
#7025 EnrichedLog netcoreapp3.1 5.5μs 3.37ns 12.6ns 0 0 0 1.63 KB
#7025 EnrichedLog net472 6.49μs 5.85ns 22.6ns 0.294 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7025 StartFinishSpan net6.0 744ns 2.8ns 10.8ns 0 0 0 576 B
#7025 StartFinishSpan netcoreapp3.1 964ns 4.42ns 17.1ns 0 0 0 576 B
#7025 StartFinishSpan net472 884ns 0.483ns 1.87ns 0.0889 0 0 578 B
#7025 StartFinishScope net6.0 919ns 0.311ns 1.2ns 0 0 0 696 B
#7025 StartFinishScope netcoreapp3.1 1.16μs 6.08ns 31.6ns 0 0 0 696 B
#7025 StartFinishScope net472 1.14μs 0.289ns 1.12ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7025

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7025 RunOnMethodBegin net6.0 1.07μs 5.71ns 22.8ns 0 0 0 696 B
#7025 RunOnMethodBegin netcoreapp3.1 1.38μs 7.16ns 34.3ns 0 0 0 696 B
#7025 RunOnMethodBegin net472 1.4μs 2.09ns 8.11ns 0.104 0 0 658 B

pr-commenter[bot] avatar May 28 '25 13:05 pr-commenter[bot]

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer. The diff is simplistic, so please check some files anyway while we improve it.

github-actions[bot] avatar Jul 21 '25 13:07 github-actions[bot]