dd-trace-dotnet
dd-trace-dotnet copied to clipboard
Published
20 hours ago •
DataDog
DataDog
[v3-main] Add #nullable enable to all public types
Summary of changes
Add #nullable enable on all public classes that can't be changed on the main 2.0 branch, as it would be a breaking change.
Replaces: https://github.com/DataDog/dd-trace-dotnet/pull/5597
Reason for change
#nullable enable is good.
Test coverage
As this PR aims not to change behaviour, just remove the possibility for null ref exceptions, the existing tests should serve as non-regression, no new test should be needed.
Datadog Report
Branch report: robert/v3/question-everything
Commit report: 8580735
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 419898 Passed, 3198 Skipped, 34h 44m 43.27s Total Time :snowflake: 1 New Flaky
New Flaky Tests (1)
-
CheckGitMetataFromEnvironmentVariables-Datadog.Profiler.IntegrationTests.DebugInfo.GitMetadataTest- Last FailureExpand for error
he test Samples.BuggyBits is running for too long or was lost
![datadog-ddstaging[bot] avatar](https://avatars.githubusercontent.com/u/365230?v=4 "Published by a pub.dev verified publisher"){kind=small}
Execution-Time Benchmarks Report :stopwatch:
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
- Welch test with statistical test for significance of 5%
- Only results indicating a difference greater than 5% and 5 ms are considered.
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5659) - mean (73ms) : 67, 80
. : milestone, 73,
master - mean (74ms) : 61, 87
. : milestone, 74,
section CallTarget+Inlining+NGEN
This PR (5659) - mean (1,001ms) : 977, 1024
. : milestone, 1001,
master - mean (979ms) : 954, 1005
. : milestone, 979,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5659) - mean (108ms) : 105, 112
. : milestone, 108,
master - mean (109ms) : 106, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (5659) - mean (713ms) : 688, 738
. : milestone, 713,
master - mean (687ms) : 666, 709
. : milestone, 687,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5659) - mean (93ms) : 90, 97
. : milestone, 93,
master - mean (92ms) : 90, 95
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (5659) - mean (665ms) : 636, 693
. : milestone, 665,
master - mean (650ms) : 627, 673
. : milestone, 650,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5659) - mean (193ms) : 188, 199
. : milestone, 193,
master - mean (191ms) : 188, 193
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (5659) - mean (1,104ms) : 1080, 1129
. : milestone, 1104,
master - mean (1,072ms) : 1046, 1097
. : milestone, 1072,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5659) - mean (278ms) : 272, 285
. : milestone, 278,
master - mean (278ms) : 273, 282
. : milestone, 278,
section CallTarget+Inlining+NGEN
This PR (5659) - mean (896ms) : 869, 922
. : milestone, 896,
master - mean (861ms) : 835, 887
. : milestone, 861,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5659) - mean (267ms) : 263, 272
. : milestone, 267,
master - mean (267ms) : 262, 272
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (5659) - mean (862ms) : 841, 883
. : milestone, 862,
master - mean (844ms) : 820, 868
. : milestone, 844,
Throughput/Crank Report :zap:
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5659) (11.399M) : 0, 11399399
master (11.699M) : 0, 11699133
benchmarks/2.9.0 (11.418M) : 0, 11417530
section Automatic
This PR (5659) (7.553M) : 0, 7553466
master (7.805M) : 0, 7805369
benchmarks/2.9.0 (8.116M) : 0, 8115541
section Trace stats
master (8.121M) : 0, 8120727
section Manual
master (9.993M) : 0, 9993490
section Manual + Automatic
This PR (5659) (7.150M) : 0, 7149607
master (7.512M) : 0, 7511907
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5659) (9.275M) : 0, 9275111
master (9.497M) : 0, 9497327
benchmarks/2.9.0 (9.669M) : 0, 9669411
section Automatic
This PR (5659) (6.629M) : 0, 6629290
master (6.597M) : 0, 6597128
section Trace stats
master (6.964M) : 0, 6963538
section Manual
master (8.201M) : 0, 8201410
section Manual + Automatic
This PR (5659) (6.162M) : 0, 6162465
master (6.259M) : 0, 6258687
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5659) (9.933M) : 0, 9932741
master (9.730M) : 0, 9729759
benchmarks/2.9.0 (9.964M) : 0, 9963943
section Automatic
This PR (5659) (7.078M) : 0, 7078177
master (6.823M) : 0, 6823234
benchmarks/2.9.0 (7.246M) : 0, 7245924
section Trace stats
master (7.345M) : 0, 7345017
section Manual
master (8.570M) : 0, 8570103
section Manual + Automatic
This PR (5659) (6.737M) : 0, 6737395
master (6.634M) : 0, 6633828
Benchmarks Report for appsec :snail:
Benchmarks for #5659 compared to master:
- All benchmarks have the same speed
- 3 benchmarks have fewer allocations
- 1 benchmarks have more allocations
The following thresholds were used for comparing the benchmark speeds:
- Mann–Whitney U test with statistical test for significance of 5%
- Only results indicating a difference greater than 10% and 0.3 ns are considered.
Allocation changes below 0.5% are ignored.
Benchmark details
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | AllCycleSimpleBody |
net6.0 | 71.9μs | 91.5ns | 354ns | 0.072 | 0 | 0 | 6 KB |
| master | AllCycleSimpleBody |
netcoreapp3.1 | 61.8μs | 127ns | 491ns | 0.0923 | 0 | 0 | 6.94 KB |
| master | AllCycleSimpleBody |
net472 | 48.5μs | 70.5ns | 264ns | 1.31 | 0 | 0 | 8.33 KB |
| master | AllCycleMoreComplexBody |
net6.0 | 77.5μs | 124ns | 480ns | 0.115 | 0 | 0 | 9.5 KB |
| master | AllCycleMoreComplexBody |
netcoreapp3.1 | 68.4μs | 66.5ns | 249ns | 0.136 | 0 | 0 | 10.36 KB |
| master | AllCycleMoreComplexBody |
net472 | 55.1μs | 49.7ns | 186ns | 1.87 | 0.0275 | 0 | 11.84 KB |
| master | ObjectExtractorSimpleBody |
net6.0 | 157ns | 0.151ns | 0.584ns | 0.00397 | 0 | 0 | 280 B |
| master | ObjectExtractorSimpleBody |
netcoreapp3.1 | 205ns | 0.684ns | 2.65ns | 0.0037 | 0 | 0 | 272 B |
| master | ObjectExtractorSimpleBody |
net472 | 173ns | 0.183ns | 0.708ns | 0.0446 | 0 | 0 | 281 B |
| master | ObjectExtractorMoreComplexBody |
net6.0 | 3.05μs | 1.99ns | 7.69ns | 0.0526 | 0 | 0 | 3.78 KB |
| master | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 3.96μs | 3.05ns | 11.8ns | 0.0493 | 0 | 0 | 3.69 KB |
| master | ObjectExtractorMoreComplexBody |
net472 | 3.78μs | 2.25ns | 8.71ns | 0.603 | 0.00565 | 0 | 3.8 KB |
| #5659 | AllCycleSimpleBody |
net6.0 | 75.4μs | 361ns | 1.8μs | 0.0743 | 0 | 0 | 6 KB |
| #5659 | AllCycleSimpleBody |
netcoreapp3.1 | 62.4μs | 89.2ns | 346ns | 0.0933 | 0 | 0 | 6.94 KB |
| #5659 | AllCycleSimpleBody |
net472 | 49.4μs | 31.8ns | 119ns | 1.31 | 0 | 0 | 8.32 KB |
| #5659 | AllCycleMoreComplexBody |
net6.0 | 80.3μs | 82.8ns | 321ns | 0.12 | 0 | 0 | 9.5 KB |
| #5659 | AllCycleMoreComplexBody |
netcoreapp3.1 | 70.9μs | 109ns | 407ns | 0.141 | 0 | 0 | 10.36 KB |
| #5659 | AllCycleMoreComplexBody |
net472 | 56.7μs | 89.3ns | 334ns | 1.87 | 0.0283 | 0 | 11.84 KB |
| #5659 | ObjectExtractorSimpleBody |
net6.0 | 150ns | 0.182ns | 0.68ns | 0.00393 | 0 | 0 | 280 B |
| #5659 | ObjectExtractorSimpleBody |
netcoreapp3.1 | 197ns | 0.257ns | 0.963ns | 0.00383 | 0 | 0 | 272 B |
| #5659 | ObjectExtractorSimpleBody |
net472 | 179ns | 0.166ns | 0.643ns | 0.0446 | 0 | 0 | 281 B |
| #5659 | ObjectExtractorMoreComplexBody |
net6.0 | 3.06μs | 1.44ns | 5.4ns | 0.0532 | 0 | 0 | 3.78 KB |
| #5659 | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 3.96μs | 1.75ns | 6.76ns | 0.0499 | 0 | 0 | 3.69 KB |
| #5659 | ObjectExtractorMoreComplexBody |
net472 | 3.78μs | 3.37ns | 13ns | 0.602 | 0.00566 | 0 | 3.8 KB |
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EncodeArgs |
net6.0 | 38.5μs | 26.6ns | 103ns | 0.459 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
netcoreapp3.1 | 54μs | 31.1ns | 121ns | 0.43 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
net472 | 66.3μs | 36.7ns | 142ns | 5.15 | 0.066 | 0 | 32.5 KB |
| master | EncodeLegacyArgs |
net6.0 | 75μs | 419ns | 2.87μs | 0.0361 | 0 | 0 | 2.14 KB |
| master | EncodeLegacyArgs |
netcoreapp3.1 | 105μs | 296ns | 1.14μs | 0 | 0 | 0 | 2.14 KB |
| master | EncodeLegacyArgs |
net472 | 154μs | 86ns | 333ns | 0.309 | 0 | 0 | 2.15 KB |
| #5659 | EncodeArgs |
net6.0 | 39.5μs | 20.7ns | 80.3ns | 0.454 | 0 | 0 | 32.4 KB |
| #5659 | EncodeArgs |
netcoreapp3.1 | 53.9μs | 25.3ns | 94.7ns | 0.432 | 0 | 0 | 32.4 KB |
| #5659 | EncodeArgs |
net472 | 68.3μs | 27.5ns | 103ns | 5.15 | 0.0682 | 0 | 32.5 KB |
| #5659 | EncodeLegacyArgs |
net6.0 | 74.3μs | 47.2ns | 183ns | 0 | 0 | 0 | 2.14 KB |
| #5659 | EncodeLegacyArgs |
netcoreapp3.1 | 104μs | 36.4ns | 126ns | 0 | 0 | 0 | 2.14 KB |
| #5659 | EncodeLegacyArgs |
net472 | 157μs | 118ns | 459ns | 0.316 | 0 | 0 | 2.15 KB |
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunWafRealisticBenchmark |
net6.0 | 182μs | 62.1ns | 240ns | 0 | 0 | 0 | 2.42 KB |
| master | RunWafRealisticBenchmark |
netcoreapp3.1 | 194μs | 121ns | 438ns | 0 | 0 | 0 | 2.37 KB |
| master | RunWafRealisticBenchmark |
net472 | 215μs | 71.2ns | 276ns | 0.323 | 0 | 0 | 2.43 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net6.0 | 121μs | 69.2ns | 268ns | 0 | 0 | 0 | 1.46 KB |
| master | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 130μs | 125ns | 483ns | 0 | 0 | 0 | 1.45 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net472 | 142μs | 97.4ns | 377ns | 0.211 | 0 | 0 | 1.48 KB |
| #5659 | RunWafRealisticBenchmark |
net6.0 | 183μs | 142ns | 551ns | 0 | 0 | 0 | 2.42 KB |
| #5659 | RunWafRealisticBenchmark |
netcoreapp3.1 | 198μs | 168ns | 650ns | 0 | 0 | 0 | 2.37 KB |
| #5659 | RunWafRealisticBenchmark |
net472 | 217μs | 56.9ns | 197ns | 0.326 | 0 | 0 | 2.43 KB |
| #5659 | RunWafRealisticBenchmarkWithAttack |
net6.0 | 122μs | 92.8ns | 359ns | 0 | 0 | 0 | 1.46 KB |
| #5659 | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 133μs | 294ns | 1.1μs | 0 | 0 | 0 | 1.45 KB |
| #5659 | RunWafRealisticBenchmarkWithAttack |
net472 | 144μs | 90.6ns | 351ns | 0.215 | 0 | 0 | 1.48 KB |
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning:
More allocations :warning: in #5659
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1
254.11 KB
264.28 KB
10.17 KB
4.00%
Fewer allocations :tada: in #5659
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472
286.72 KB
278.53 KB
-8.19 KB
-2.86%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0
264.66 KB
254.86 KB
-9.81 KB
-3.71%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472
61.65 KB
59.22 KB
-2.42 KB
-3.93%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark |
net6.0 | 52.1μs | 241ns | 963ns | 0 | 0 | 0 | 43.44 KB |
| master | StringConcatBenchmark |
netcoreapp3.1 | 53.2μs | 228ns | 882ns | 0 | 0 | 0 | 42.64 KB |
| master | StringConcatBenchmark |
net472 | 37.5μs | 94.8ns | 355ns | 0 | 0 | 0 | 61.65 KB |
| master | StringConcatAspectBenchmark |
net6.0 | 298μs | 731ns | 2.64μs | 0 | 0 | 0 | 264.66 KB |
| master | StringConcatAspectBenchmark |
netcoreapp3.1 | 344μs | 1.85μs | 14.3μs | 0 | 0 | 0 | 254.11 KB |
| master | StringConcatAspectBenchmark |
net472 | 257μs | 1.43μs | 8.72μs | 0 | 0 | 0 | 286.72 KB |
| #5659 | StringConcatBenchmark |
net6.0 | 57.9μs | 658ns | 6.48μs | 0 | 0 | 0 | 43.44 KB |
| #5659 | StringConcatBenchmark |
netcoreapp3.1 | 54.1μs | 237ns | 856ns | 0 | 0 | 0 | 42.64 KB |
| #5659 | StringConcatBenchmark |
net472 | 38.6μs | 72.1ns | 260ns | 0 | 0 | 0 | 59.22 KB |
| #5659 | StringConcatAspectBenchmark |
net6.0 | 307μs | 1.5μs | 6.37μs | 0 | 0 | 0 | 254.86 KB |
| #5659 | StringConcatAspectBenchmark |
netcoreapp3.1 | 350μs | 1.98μs | 13.3μs | 0 | 0 | 0 | 264.28 KB |
| #5659 | StringConcatAspectBenchmark |
net472 | 302μs | 7.78μs | 75μs | 0 | 0 | 0 | 278.53 KB |
Benchmarks Report for tracer :snail:
Benchmarks for #5659 compared to master:
- 2 benchmarks are faster, with geometric mean 1.142
- 1 benchmarks have more allocations
The following thresholds were used for comparing the benchmark speeds:
- Mann–Whitney U test with statistical test for significance of 5%
- Only results indicating a difference greater than 10% and 0.3 ns are considered.
Allocation changes below 0.5% are ignored.
Benchmark details
Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 8.83μs | 48.7ns | 288ns | 0.0212 | 0.00848 | 0 | 7.68 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 10.6μs | 54.2ns | 242ns | 0.0324 | 0.0162 | 0 | 7.78 KB |
| master | StartStopWithChild |
net472 | 17.3μs | 40.9ns | 153ns | 1.39 | 0.361 | 0.129 | 8.2 KB |
| #5659 | StartStopWithChild |
net6.0 | 9.01μs | 49.3ns | 296ns | 0.026 | 0.00867 | 0 | 7.68 KB |
| #5659 | StartStopWithChild |
netcoreapp3.1 | 11.2μs | 61ns | 356ns | 0.0385 | 0.0165 | 0 | 7.77 KB |
| #5659 | StartStopWithChild |
net472 | 17.6μs | 58.1ns | 225ns | 1.39 | 0.371 | 0.115 | 8.21 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 491μs | 127ns | 493ns | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 661μs | 258ns | 998ns | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 847μs | 226ns | 844ns | 0.425 | 0 | 0 | 3.3 KB |
| #5659 | WriteAndFlushEnrichedTraces |
net6.0 | 471μs | 284ns | 1.1μs | 0 | 0 | 0 | 2.7 KB |
| #5659 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 634μs | 262ns | 944ns | 0 | 0 | 0 | 2.7 KB |
| #5659 | WriteAndFlushEnrichedTraces |
net472 | 833μs | 178ns | 691ns | 0.417 | 0 | 0 | 3.3 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 169μs | 166ns | 645ns | 0.169 | 0 | 0 | 18.44 KB |
| master | SendRequest |
netcoreapp3.1 | 193μs | 465ns | 1.8μs | 0.195 | 0 | 0 | 20.6 KB |
| master | SendRequest |
net472 | 0.000448ns | 0.000256ns | 0.000957ns | 0 | 0 | 0 | 0 b |
| #5659 | SendRequest |
net6.0 | 173μs | 247ns | 956ns | 0.259 | 0 | 0 | 18.44 KB |
| #5659 | SendRequest |
netcoreapp3.1 | 193μs | 452ns | 1.75μs | 0.145 | 0 | 0 | 20.6 KB |
| #5659 | SendRequest |
net472 | 0.00204ns | 0.000639ns | 0.00247ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning:
More allocations :warning: in #5659
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1
41.61 KB
42.11 KB
494 B
1.19%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 539μs | 2.12μs | 8.22μs | 0.553 | 0 | 0 | 41.49 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 652μs | 982ns | 3.8μs | 0.324 | 0 | 0 | 41.61 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 892μs | 2.95μs | 11.4μs | 8.42 | 2.66 | 0.443 | 53.25 KB |
| #5659 | WriteAndFlushEnrichedTraces |
net6.0 | 556μs | 323ns | 1.21μs | 0.541 | 0 | 0 | 41.69 KB |
| #5659 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 650μs | 1.41μs | 5.44μs | 0.331 | 0 | 0 | 42.11 KB |
| #5659 | WriteAndFlushEnrichedTraces |
net472 | 839μs | 2.25μs | 8.41μs | 8.19 | 2.59 | 0.431 | 53.22 KB |
Benchmarks.Trace.DbCommandBenchmark - Faster :tada: Same allocations :heavy_check_mark:
Faster :tada: in #5659
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1
1.115
1,543.82
1,384.29
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.14μs | 0.619ns | 2.4ns | 0.0111 | 0 | 0 | 808 B |
| master | ExecuteNonQuery |
netcoreapp3.1 | 1.54μs | 0.497ns | 1.92ns | 0.0107 | 0 | 0 | 808 B |
| master | ExecuteNonQuery |
net472 | 1.73μs | 2.69ns | 10.4ns | 0.122 | 0 | 0 | 770 B |
| #5659 | ExecuteNonQuery |
net6.0 | 1.14μs | 1.03ns | 3.97ns | 0.0109 | 0 | 0 | 808 B |
| #5659 | ExecuteNonQuery |
netcoreapp3.1 | 1.38μs | 0.505ns | 1.96ns | 0.0104 | 0 | 0 | 808 B |
| #5659 | ExecuteNonQuery |
net472 | 1.72μs | 2.15ns | 8.34ns | 0.122 | 0 | 0 | 770 B |
Benchmarks.Trace.ElasticsearchBenchmark - Faster :tada: Same allocations :heavy_check_mark:
Faster :tada: in #5659
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0
1.169
1,232.49
1,054.49
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.23μs | 0.711ns | 2.75ns | 0.0135 | 0 | 0 | 976 B |
| master | CallElasticsearch |
netcoreapp3.1 | 1.49μs | 0.308ns | 1.15ns | 0.0133 | 0 | 0 | 976 B |
| master | CallElasticsearch |
net472 | 2.4μs | 1.87ns | 7.25ns | 0.158 | 0 | 0 | 995 B |
| master | CallElasticsearchAsync |
net6.0 | 1.32μs | 0.578ns | 2.24ns | 0.0132 | 0 | 0 | 952 B |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 1.68μs | 0.975ns | 3.65ns | 0.0133 | 0 | 0 | 1.02 KB |
| master | CallElasticsearchAsync |
net472 | 2.55μs | 1.82ns | 6.82ns | 0.167 | 0 | 0 | 1.05 KB |
| #5659 | CallElasticsearch |
net6.0 | 1.05μs | 0.574ns | 2.15ns | 0.0137 | 0 | 0 | 976 B |
| #5659 | CallElasticsearch |
netcoreapp3.1 | 1.5μs | 1.02ns | 3.69ns | 0.0134 | 0 | 0 | 976 B |
| #5659 | CallElasticsearch |
net472 | 2.52μs | 3.56ns | 13.3ns | 0.158 | 0.00126 | 0 | 995 B |
| #5659 | CallElasticsearchAsync |
net6.0 | 1.21μs | 0.62ns | 2.32ns | 0.0133 | 0 | 0 | 952 B |
| #5659 | CallElasticsearchAsync |
netcoreapp3.1 | 1.58μs | 0.709ns | 2.65ns | 0.0142 | 0 | 0 | 1.02 KB |
| #5659 | CallElasticsearchAsync |
net472 | 2.64μs | 4.3ns | 16.1ns | 0.166 | 0.00131 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.3μs | 0.669ns | 2.59ns | 0.0131 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 1.62μs | 0.761ns | 2.85ns | 0.0129 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 1.7μs | 1.47ns | 5.29ns | 0.145 | 0.000847 | 0 | 915 B |
| #5659 | ExecuteAsync |
net6.0 | 1.22μs | 0.445ns | 1.72ns | 0.0135 | 0 | 0 | 952 B |
| #5659 | ExecuteAsync |
netcoreapp3.1 | 1.69μs | 0.758ns | 2.84ns | 0.0125 | 0 | 0 | 952 B |
| #5659 | ExecuteAsync |
net472 | 1.74μs | 0.655ns | 2.54ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 4.07μs | 1.51ns | 5.63ns | 0.0305 | 0 | 0 | 2.22 KB |
| master | SendAsync |
netcoreapp3.1 | 5.22μs | 27.9ns | 220ns | 0.0356 | 0 | 0 | 2.76 KB |
| master | SendAsync |
net472 | 7.45μs | 3.2ns | 12.4ns | 0.496 | 0 | 0 | 3.12 KB |
| #5659 | SendAsync |
net6.0 | 4.26μs | 2.01ns | 7.51ns | 0.0298 | 0 | 0 | 2.22 KB |
| #5659 | SendAsync |
netcoreapp3.1 | 5.06μs | 2.03ns | 7.88ns | 0.0357 | 0 | 0 | 2.76 KB |
| #5659 | SendAsync |
net472 | 7.61μs | 3.06ns | 11.9ns | 0.493 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 1.45μs | 3.95ns | 15.3ns | 0.0229 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
netcoreapp3.1 | 2.3μs | 13.4ns | 125ns | 0.0215 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
net472 | 2.52μs | 0.719ns | 2.69ns | 0.249 | 0 | 0 | 1.57 KB |
| #5659 | EnrichedLog |
net6.0 | 1.42μs | 0.512ns | 1.91ns | 0.0233 | 0 | 0 | 1.64 KB |
| #5659 | EnrichedLog |
netcoreapp3.1 | 2.31μs | 1.05ns | 3.77ns | 0.022 | 0 | 0 | 1.64 KB |
| #5659 | EnrichedLog |
net472 | 2.58μs | 1.97ns | 7.63ns | 0.25 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 115μs | 43.5ns | 157ns | 0.0576 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
netcoreapp3.1 | 121μs | 180ns | 696ns | 0.0606 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
net472 | 149μs | 78.3ns | 303ns | 0.672 | 0.224 | 0 | 4.46 KB |
| #5659 | EnrichedLog |
net6.0 | 116μs | 88.8ns | 344ns | 0.0582 | 0 | 0 | 4.28 KB |
| #5659 | EnrichedLog |
netcoreapp3.1 | 120μs | 153ns | 592ns | 0 | 0 | 0 | 4.28 KB |
| #5659 | EnrichedLog |
net472 | 151μs | 125ns | 484ns | 0.674 | 0.225 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 3.1μs | 2.2ns | 8.22ns | 0.0309 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
netcoreapp3.1 | 4.27μs | 1.96ns | 7.6ns | 0.0299 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
net472 | 4.87μs | 2.22ns | 8.61ns | 0.319 | 0 | 0 | 2.02 KB |
| #5659 | EnrichedLog |
net6.0 | 3.05μs | 1.17ns | 4.54ns | 0.0304 | 0 | 0 | 2.2 KB |
| #5659 | EnrichedLog |
netcoreapp3.1 | 4.22μs | 1.27ns | 4.92ns | 0.0292 | 0 | 0 | 2.2 KB |
| #5659 | EnrichedLog |
net472 | 4.83μs | 1.36ns | 5.26ns | 0.319 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 1.35μs | 0.503ns | 1.95ns | 0.0162 | 0 | 0 | 1.14 KB |
| master | SendReceive |
netcoreapp3.1 | 1.75μs | 1.05ns | 4.05ns | 0.0157 | 0 | 0 | 1.14 KB |
| master | SendReceive |
net472 | 2.11μs | 1.66ns | 6.22ns | 0.183 | 0 | 0 | 1.16 KB |
| #5659 | SendReceive |
net6.0 | 1.31μs | 0.5ns | 1.94ns | 0.0158 | 0 | 0 | 1.14 KB |
| #5659 | SendReceive |
netcoreapp3.1 | 1.73μs | 1ns | 3.88ns | 0.0156 | 0 | 0 | 1.14 KB |
| #5659 | SendReceive |
net472 | 2.01μs | 1.49ns | 5.56ns | 0.183 | 0.001 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.72μs | 0.637ns | 2.3ns | 0.0217 | 0 | 0 | 1.6 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.97μs | 1.97ns | 7.64ns | 0.0219 | 0 | 0 | 1.65 KB |
| master | EnrichedLog |
net472 | 4.22μs | 2.83ns | 10.9ns | 0.322 | 0 | 0 | 2.04 KB |
| #5659 | EnrichedLog |
net6.0 | 2.77μs | 0.756ns | 2.83ns | 0.0221 | 0 | 0 | 1.6 KB |
| #5659 | EnrichedLog |
netcoreapp3.1 | 4.03μs | 7.73ns | 29.9ns | 0.0219 | 0 | 0 | 1.65 KB |
| #5659 | EnrichedLog |
net472 | 4.51μs | 9.11ns | 35.3ns | 0.322 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 395ns | 0.291ns | 1.13ns | 0.00804 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 538ns | 0.828ns | 3.21ns | 0.00785 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 570ns | 0.402ns | 1.56ns | 0.0916 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 509ns | 0.177ns | 0.663ns | 0.00981 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 760ns | 1.58ns | 5.89ns | 0.00943 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 807ns | 0.704ns | 2.73ns | 0.104 | 0 | 0 | 658 B |
| #5659 | StartFinishSpan |
net6.0 | 407ns | 0.246ns | 0.952ns | 0.00818 | 0 | 0 | 576 B |
| #5659 | StartFinishSpan |
netcoreapp3.1 | 565ns | 0.361ns | 1.3ns | 0.00773 | 0 | 0 | 576 B |
| #5659 | StartFinishSpan |
net472 | 619ns | 0.467ns | 1.81ns | 0.0915 | 0 | 0 | 578 B |
| #5659 | StartFinishScope |
net6.0 | 529ns | 0.324ns | 1.25ns | 0.00983 | 0 | 0 | 696 B |
| #5659 | StartFinishScope |
netcoreapp3.1 | 757ns | 0.278ns | 1.08ns | 0.00967 | 0 | 0 | 696 B |
| #5659 | StartFinishScope |
net472 | 812ns | 0.45ns | 1.74ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 677ns | 0.417ns | 1.61ns | 0.00974 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 887ns | 0.48ns | 1.86ns | 0.00938 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.12μs | 0.742ns | 2.87ns | 0.104 | 0 | 0 | 658 B |
| #5659 | RunOnMethodBegin |
net6.0 | 649ns | 0.5ns | 1.94ns | 0.00964 | 0 | 0 | 696 B |
| #5659 | RunOnMethodBegin |
netcoreapp3.1 | 931ns | 0.799ns | 3.1ns | 0.00954 | 0 | 0 | 696 B |
| #5659 | RunOnMethodBegin |
net472 | 1.03μs | 0.406ns | 1.57ns | 0.104 | 0 | 0 | 658 B |