dd-sdk-ios icon indicating copy to clipboard operation
dd-sdk-ios copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

Support sendable in OTSpan

Open muukii opened this issue 2 years ago • 5 comments
trafficstars

The thing

in some cases, potentially moving between threads(actors)

muukii avatar Aug 26 '23 17:08 muukii

Thanks for opening the issue @muukii

We have not looked into supporting Swift concurrency features but this is interesting use case. Conforming OTSpan to Sendable will not be trivial because of DDSpan which opens up all other types. Hence, we have to figure out a strategy for conformation.

Let me discuss with the team and will get back to you.

ganeshnj avatar Aug 28 '23 15:08 ganeshnj

Okay, thanks for replying.

In Swift6, swift-concurrency will be enhanced, and errors when it comes to using UNSAFE multi-threading programming. It boils down to supporting swift-concurrency attributes such as Sendable to prevent errors. I probably help this project.

muukii avatar Aug 30 '23 08:08 muukii

We discussed this internally and created a backlog item for prioritization. The use case mentioned makes sense where we want SDK's public types to be thread safe even if the SDK doesn't use any Swift concurrency features.

Keep an eye on this issue for further updates.

ganeshnj avatar Sep 13 '23 08:09 ganeshnj

@ganeshnj Do ya'll have a target date by which you plan to be ready for Swift 6 and strict concurrency?

jaredsinclair avatar Mar 29 '24 18:03 jaredsinclair

We have bumped the priority of the backlog item to highest. Unfortunately, we don't have date to share as it would require some significant changes how we handle things.

We will keep the issue updated.

ganeshnj avatar Apr 04 '24 14:04 ganeshnj