dd-sdk-android
dd-sdk-android copied to clipboard
RUM-5763: Add TouchPrivacy to Session Replay
What does this PR do?
Adds a TouchPrivacy api. For the moment this api is internal, and will become public later.
Possible values for touch:
SHOW - record all touch interactions
HIDE - do not record touch interactions
Usage example:
SessionReplayConfiguration.Builder()
.setTouchPrivacy(TouchPrivacy.SHOW)
Note: At the moment this will not hide the change in a button background that occurs as a result of a click (or other view hierarchy side effects).
Motivation
Part of the move to fine grained privacy options.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)
- [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
- [ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.01%. Comparing base (
0b04b79) to head (52c56c2). Report is 2 commits behind head on feature/fine-grained-masking.
Additional details and impacted files
@@ Coverage Diff @@
## feature/fine-grained-masking #2196 +/- ##
================================================================
+ Coverage 69.94% 70.01% +0.07%
================================================================
Files 726 727 +1
Lines 27026 27015 -11
Branches 4543 4535 -8
================================================================
+ Hits 18902 18912 +10
+ Misses 6842 6834 -8
+ Partials 1282 1269 -13
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...com/datadog/android/sessionreplay/SessionReplay.kt | 50.00% <100.00%> (+2.38%) |
:arrow_up: |
| ...ndroid/sessionreplay/SessionReplayConfiguration.kt | 100.00% <100.00%> (ø) |
|
| .../com/datadog/android/sessionreplay/TouchPrivacy.kt | 100.00% <100.00%> (ø) |
|
| .../sessionreplay/internal/DefaultRecorderProvider.kt | 93.44% <100.00%> (+0.11%) |
:arrow_up: |
| ...oid/sessionreplay/internal/SessionReplayFeature.kt | 98.69% <100.00%> (+0.03%) |
:arrow_up: |
| ...nreplay/internal/recorder/SessionReplayRecorder.kt | 96.90% <100.00%> (+0.07%) |
:arrow_up: |
| ...lay/internal/recorder/WindowCallbackInterceptor.kt | 100.00% <100.00%> (ø) |
|
| ...ternal/recorder/callback/RecorderWindowCallback.kt | 91.67% <100.00%> (+0.20%) |
:arrow_up: |