dd-sdk-android icon indicating copy to clipboard operation
dd-sdk-android copied to clipboard

Removes log and trace articles

Open rtrieu opened this issue 1 year ago • 3 comments

What does this PR do?

Removes log and trace articles that have been un-single sourced from this repo. They now live in:

  • https://docs.datadoghq.com/logs/log_collection/android/
  • https://docs.datadoghq.com/tracing/trace_collection/automatic_instrumentation/dd_libraries/android/

Motivation

What inspired you to submit this pull request?

  • Was notified they were still in the repo.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • [ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

rtrieu avatar Aug 01 '24 16:08 rtrieu

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.95%. Comparing base (b626681) to head (fd95523).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2159      +/-   ##
===========================================
- Coverage    70.10%   69.95%   -0.15%     
===========================================
  Files          726      726              
  Lines        27009    27001       -8     
  Branches      4528     4528              
===========================================
- Hits         18932    18886      -46     
- Misses        6823     6835      +12     
- Partials      1254     1280      +26     

see 33 files with indirect coverage changes

codecov-commenter avatar Aug 01 '24 16:08 codecov-commenter

Hi @DataDog/rum-mobile-android Can you merge this when you get the chance? Thanks!

rtrieu avatar Aug 07 '24 13:08 rtrieu

@rtrieu Hey, it seems your last commit in the PR is not signed, can you sign the commit and repush the branch? I will approve and merge it

ambushwork avatar Aug 08 '24 12:08 ambushwork