datadog-operator icon indicating copy to clipboard operation
datadog-operator copied to clipboard

[CONTINT-4643] Add an option to configure KSM custom resource metrics collection

Open L3n41c opened this issue 6 months ago • 1 comments

What does this PR do?

Add an datadog parameter to configure custom resources metrics collection introduced in DataDog/datadog-agent#31715.

Motivation

Additional Notes

This the datadog-operator equivalent of DataDog/helm-charts#1883.

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: v7.63.0 (if kubernetes-state-core is running on cluster checks runners)
  • Cluster Agent: v7.63.0 (otherwise)

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • [ ] PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • [ ] PR has a milestone or the qa/skip-qa label

L3n41c avatar May 23 '25 13:05 L3n41c

Codecov Report

:x: Patch coverage is 92.00000% with 6 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.10%. Comparing base (977f372) to head (1188d65). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...agent/feature/kubernetesstatecore/indent_writer.go 76.00% 4 Missing and 2 partials :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1927      +/-   ##
==========================================
+ Coverage   38.97%   39.10%   +0.13%     
==========================================
  Files         253      254       +1     
  Lines       26208    26275      +67     
==========================================
+ Hits        10214    10275      +61     
- Misses      15386    15390       +4     
- Partials      608      610       +2     
Flag Coverage Δ
unittests 39.10% <92.00%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...adogagent/feature/kubernetesstatecore/configmap.go 96.20% <100.00%> (+0.96%) :arrow_up:
...atadogagent/feature/kubernetesstatecore/feature.go 71.52% <100.00%> (+0.40%) :arrow_up:
...r/datadogagent/feature/kubernetesstatecore/rbac.go 100.00% <100.00%> (ø)
...agent/feature/kubernetesstatecore/indent_writer.go 76.00% <76.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 977f372...1188d65. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar May 26 '25 13:05 codecov-commenter

/merge

L3n41c avatar Oct 13 '25 12:10 L3n41c

View all feedbacks in Devflow UI.

2025-10-13 12:03:09 UTC :information_source: Start processing command /merge


2025-10-13 12:03:15 UTC :information_source: MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).


2025-10-13 14:03:41 UTC :x: MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 79133870 took longer than expected. The current limit for the base branch 'main' is 120 minutes.

/merge

L3n41c avatar Oct 14 '25 09:10 L3n41c

View all feedbacks in Devflow UI.

2025-10-14 09:39:17 UTC :information_source: Start processing command /merge


2025-10-14 09:39:23 UTC :information_source: MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).


2025-10-14 11:39:42 UTC :x: MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 79210032 took longer than expected. The current limit for the base branch 'main' is 120 minutes.