datadog-operator
datadog-operator copied to clipboard
Do not mount /etc/passwd on Talos nodes
What does this PR do?
A brief description of the change being made with this pull request.
Disable mounting /etc/passwd in node agent containers for Talos nodes.
Tested with:
kind: "DatadogAgent"
spec:
...
features:
logCollection:
enabled: true
containerCollectAll: true
orchestratorExplorer:
enabled: true
liveProcessCollection:
enabled: true
# operator values.yaml
introspection:
enabled: true # required to detect talos
Motivation
What inspired you to submit this pull request?
https://github.com/DataDog/helm-charts/issues/273#issuecomment-2521040609
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
- Agent: vX.Y.Z
- Cluster Agent: vX.Y.Z
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
- [ ] PR has at least one valid label:
bug,enhancement,refactoring,documentation,tooling, and/ordependencies - [ ] PR has a milestone or the
qa/skip-qalabel
Codecov Report
:x: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 49.47%. Comparing base (54ed549) to head (c2abbce).
:warning: Report is 272 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/kubernetes/provider.go | 85.71% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1765 +/- ##
=======================================
Coverage 49.47% 49.47%
=======================================
Files 219 219
Lines 21356 21359 +3
=======================================
+ Hits 10565 10568 +3
Misses 10245 10245
Partials 546 546
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 49.47% <96.66%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...al/controller/datadogagent/feature/cspm/feature.go | 75.20% <100.00%> (ø) |
|
| ...nal/controller/datadogagent/feature/cws/feature.go | 79.55% <100.00%> (ø) |
|
| ...roller/datadogagent/feature/liveprocess/feature.go | 92.07% <100.00%> (ø) |
|
| ...r/datadogagent/feature/processdiscovery/feature.go | 90.00% <100.00%> (ø) |
|
| pkg/kubernetes/provider.go | 84.82% <85.71%> (+0.41%) |
:arrow_up: |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 54ed549...c2abbce. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This pull request has been automatically marked as stale because it has not had activity in the past 15 days.
It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window.
Thank you for your contributions!