datadog-operator icon indicating copy to clipboard operation
datadog-operator copied to clipboard

Watch nodes if profiles or introspection is enabled

Open khewonc opened this issue 1 year ago • 1 comments

What does this PR do?

Adds more conditionals to make make watch nodes more restrictive since we only need it for introspection or profiles

Motivation

https://datadoghq.atlassian.net/browse/CECO-1267

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: n/a
  • Cluster Agent: n/a

Describe your test plan

  • Deploy the operator with either introspection or profiles enabled
  • Changing node labels should cause an extra reconcile
  • Deploy the operator without introspection and profiles enabled
  • Changing node labels shouldn't cause a reconcile

Checklist

  • [x] PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • [x] PR has a milestone or the qa/skip-qa label

khewonc avatar Jul 03 '24 19:07 khewonc

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.84%. Comparing base (3c66816) to head (53c07a5). Report is 378 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1268   +/-   ##
=======================================
  Coverage   54.84%   54.84%           
=======================================
  Files         241      241           
  Lines       27879    27879           
=======================================
  Hits        15291    15291           
  Misses      11717    11717           
  Partials      871      871           
Flag Coverage Δ
unittests 54.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controllers/datadogagent_controller.go 70.79% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c66816...53c07a5. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jul 03 '24 19:07 codecov-commenter