datadog-operator icon indicating copy to clipboard operation
datadog-operator copied to clipboard

Add v1beta1 CRD deprection warning

Open levan-m opened this issue 1 year ago • 1 comments

What does this PR do?

Adds log line about upcoming v1beta1 CRD deprecation and warning in the readme.

Readme warning preview:

[!WARNING] Operator release v0.1.7 removes support for DatadogAgent v1alpha1 reconciliation (v2APIEnabled flag). v0.1.8 will remove conversion webhook as well and users will not be able to apply DadadogAgent v1alpha1 manifest.

Operator release v1.8.0 will deprecate CRDs of apiextensions.k8s.io/v1beta1 version. They will be kept in the repo but will not be updated. They will be removed in release v1.10.0.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • [ ] PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • [ ] PR has a milestone or the qa/skip-qa label

levan-m avatar May 24 '24 21:05 levan-m

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 59.38%. Comparing base (8981855) to head (2f51802). Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1200      +/-   ##
==========================================
+ Coverage   59.16%   59.38%   +0.21%     
==========================================
  Files         175      176       +1     
  Lines       21944    22108     +164     
==========================================
+ Hits        12984    13128     +144     
- Misses       8164     8178      +14     
- Partials      796      802       +6     
Flag Coverage Δ
unittests 59.38% <33.33%> (+0.21%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/setup.go 59.66% <33.33%> (-1.40%) :arrow_down:

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8981855...2f51802. Read the comment docs.

codecov-commenter avatar May 24 '24 21:05 codecov-commenter

Is this PR's title/changelog entry misleading?

Does the datadog-operator at version 1.8.0 no longer support v1alpha1 or v1beta1?

hjkatz avatar Aug 02 '24 19:08 hjkatz

Hello, notice is about changes coming in v1.8.0 for two different Kinds:

  • DatadogAgent v1alpha1 - Operator will not support v1alpha1 reconciliation which was possible with v2APIEnabled set to false. Conversion webhook will be removed as well, v2alpha1 will be stored, server version by default and users won't be able to apply v1alpha1 version.
  • CustomResourceDefinition v1beta1 - we will stop updating v1beta1 CRDs found here and will remove these files eventually.

levan-m avatar Aug 04 '24 05:08 levan-m