datadog-agent
datadog-agent copied to clipboard
Drop CentOS 6
What does this PR do?
This PR bumps our build images to drop CentOS 6 support and now targets CentOS 7 for RHEL derivatives. These images also bump rust to 1.64. This allows us to bump python-cryptography
Motivation
This is the preliminary work described in BARX-268 to address:
- VULN-5597
- VULN-5742
- VULN-5622
- VULN-5770
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 8ff1864a-d8d7-4313-978b-ba0daefa5436 Baseline: 3edc357af04d6ca389bdaac6de140e83ddce135f Comparison: 26cb5e294a8726d46b58efd6a12ecb17b3358a05
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -0.01 | [-6.56, +6.55] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | idle | memory utilization | +1.06 | [+1.01, +1.11] |
| ➖ | process_agent_standard_check | memory utilization | +0.79 | [+0.74, +0.83] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.38 | [+0.33, +0.42] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.02 | [+0.01, +0.04] |
| ➖ | trace_agent_json | ingress throughput | +0.02 | [-0.00, +0.04] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | file_to_blackhole | % cpu utilization | -0.01 | [-6.56, +6.55] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.06 | [-0.11, +0.00] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.11 | [-0.74, +0.52] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.25 | [-0.30, -0.20] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.36 | [-1.79, +1.07] |
| ➖ | file_tree | memory utilization | -0.77 | [-0.89, -0.66] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on
/merge
:steam_locomotive: MergeQueue
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
:warning: MergeQueue
This merge request was unqueued
If you need support, contact us on Slack #ci-interfaces!
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is next! (estimated merge in less than 28m)
Use /merge -c to cancel this operation!