Unify APM instrumentation settings

[Kyle-Verhoog]

These settings were previously specified in a separate configuration file that only the injector processes would read. This was done to accelerate development in order to get APM instrumentation released in public beta.

Now that we are looking to make APM instrumentation generally available, it makes sense to unify this configuration with the rest of the Agent configuration in the datadog.yaml.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 44d7c935-445d-43e3-8988-4897c17f6a4d Baseline: 8a928218504a6a8b89f05c17ba5093ba78056676 Comparison: 01fd23bf452900d753ddbd10d17f2136984646b9 Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.15	[-6.39, +6.69]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.74	[+1.31, +4.18]
➖	otel_to_otel_logs	ingress throughput	+2.25	[+1.65, +2.84]
➖	file_to_blackhole	% cpu utilization	+0.15	[-6.39, +6.69]
➖	idle	memory utilization	+0.10	[+0.08, +0.13]
➖	file_tree	memory utilization	+0.08	[+0.00, +0.16]
➖	process_agent_real_time_mode	memory utilization	+0.06	[+0.03, +0.09]
➖	trace_agent_json	ingress throughput	+0.04	[+0.00, +0.07]
➖	trace_agent_msgpack	ingress throughput	+0.00	[-0.01, +0.01]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	process_agent_standard_check_with_stats	memory utilization	-0.07	[-0.10, -0.03]
➖	process_agent_standard_check	memory utilization	-0.27	[-0.31, -0.23]
➖	tcp_syslog_to_blackhole	ingress throughput	-1.06	[-1.12, -1.01]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[Kyle-Verhoog]

We should make sure to report the settings via inventories: https://github.com/DataDog/datadog-agent/blob/main/comp/metadata/inventoryagent/inventoryagentimpl/inventoryagent.go#L243

thanks @avivenzio-dd!