datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

OCI: Provide the expected alternative path

Open chouquette opened this issue 1 year ago • 1 comments

What does this PR do?

This PR uses an alternative installation path that's compatible with the remote updater

Motivation

Having an artifact usable from the remote updater

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

chouquette avatar Feb 14 '24 16:02 chouquette

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: fb0fe962-e0d0-4354-beec-291766cad035 Baseline: 09ff603d4deb5997589085e20036e857edfa58af Comparison: 06e232f4fcbd7a3705a3533171b9fb8c12ce1785 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -2.62 [-9.08, +3.83]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
idle memory utilization +0.58 [+0.53, +0.63]
otel_to_otel_logs ingress throughput +0.47 [-0.13, +1.07]
tcp_syslog_to_blackhole ingress throughput +0.37 [+0.31, +0.43]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.00 [-0.03, +0.03]
process_agent_standard_check_with_stats memory utilization -0.20 [-0.25, -0.15]
process_agent_real_time_mode memory utilization -0.20 [-0.26, -0.15]
file_tree memory utilization -0.32 [-0.42, -0.23]
process_agent_standard_check memory utilization -0.39 [-0.45, -0.34]
uds_dogstatsd_to_api_cpu % cpu utilization -1.89 [-3.28, -0.51]
file_to_blackhole % cpu utilization -2.62 [-9.08, +3.83]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 14 '24 17:02 pr-commenter[bot]

/merge

chouquette avatar Feb 16 '24 08:02 chouquette

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 16 '24 08:02 dd-devflow[bot]