[CI] Remove milestone analysis workflow

[amenasria]

What does this PR do?

This PR removes the milestone Github workflow.

Motivation

Thanks to #22567 the milestone is now automatically set after merge. This is hence not needed anymore.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

• [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
• [ ] A release note has been added or the changelog/no-changelog label has been applied.
• [ ] Changed code has automated tests for its functionality.
• [ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
• [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
• [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
• [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
• [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
• [ ] If applicable, the config template has been updated.

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 4a5cb30c-3c08-48df-a82c-71bc60dc2816 Baseline: 21213ac863f4c6c5c430f4f93f76810788b27820 Comparison: b1263efa7a8d43e843ff6cf374636bbe0d7e7f74 Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.55	[-7.11, +6.01]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	tcp_syslog_to_blackhole	ingress throughput	+1.03	[+0.98, +1.09]
➖	process_agent_real_time_mode	memory utilization	+0.45	[+0.42, +0.48]
➖	process_agent_standard_check_with_stats	memory utilization	+0.10	[+0.07, +0.14]
➖	trace_agent_json	ingress throughput	+0.01	[-0.01, +0.03]
➖	trace_agent_msgpack	ingress throughput	+0.01	[+0.01, +0.02]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	otel_to_otel_logs	ingress throughput	-0.05	[-0.66, +0.56]
➖	idle	memory utilization	-0.36	[-0.40, -0.33]
➖	process_agent_standard_check	memory utilization	-0.41	[-0.47, -0.36]
➖	file_to_blackhole	% cpu utilization	-0.55	[-7.11, +6.01]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.80	[-2.24, +0.64]
➖	file_tree	memory utilization	-2.13	[-2.23, -2.02]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[amenasria]

@chouquette thanks for the ✅ !

Should the associated mention in the reviewer checklist also be removed

It will be in #22487, yes !

Should we stop providing a milestone in automated PRs?

I think both keeping / removing it is fine, but let's remove it to be consistent ! Could you give me an example where we're doing this please ?

[chouquette]

Sure thing! I was mostly thinking about the 2 auto PR workflows in omnibus repos https://github.com/DataDog/omnibus-ruby/blob/datadog-5.5.0/.github/workflows/open-datadog-agent-pr.yml#L89 and the equilvalent one in omnibus-software (same file, same line)

[amenasria]

Waiting for #22738 to be merged, since the add_milestone workflow is broken now.

[amenasria]

@chouquette good point. Here are the PRs:

• omnibus-ruby: https://github.com/DataDog/omnibus-ruby/pull/181
• omnibus-software: https://github.com/DataDog/omnibus-software/pull/509

[amenasria]

The Add milestone workflow is working 🎉

[amenasria]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

[amenasria]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

[agent-platform-auto-pr[bot]]

[Fast Unit Tests Report]

On pipeline 34125447 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: aa30a870-3ec5-4e08-be36-379a29943f8d Baseline: ac80dd7e9c78b8883200ead3047579b07e4bae72 Comparison: af656700d50ef965fe1c6ffbb93d292bd4068cfa

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
✅	file_to_blackhole	% cpu utilization	-23.59	[-27.77, -19.40]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	tcp_syslog_to_blackhole	ingress throughput	+6.39	[-15.52, +28.29]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.28	[-1.57, +4.13]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.02	[-0.02, +0.06]
➖	trace_agent_msgpack	ingress throughput	+0.01	[+0.01, +0.02]
➖	otel_to_otel_logs	ingress throughput	+0.00	[-0.36, +0.36]
➖	trace_agent_json	ingress throughput	+0.00	[-0.01, +0.01]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.20, +0.20]
➖	idle	memory utilization	-0.03	[-0.06, +0.00]
➖	file_tree	memory utilization	-0.05	[-0.14, +0.03]
➖	basic_py_check	% cpu utilization	-0.47	[-2.89, +1.95]
➖	pycheck_1000_100byte_tags	% cpu utilization	-0.51	[-5.40, +4.37]
✅	file_to_blackhole	% cpu utilization	-23.59	[-27.77, -19.40]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[amenasria]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!