Add agentless-scanner

[0intro]

What does this PR do?

This change adds the agentless-scanner software.

Development branch. Not for review.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

• [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
• [ ] A release note has been added or the changelog/no-changelog label has been applied.
• [ ] Changed code has automated tests for its functionality.
• [ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
• [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
• [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
• [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
• [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
• [ ] If applicable, the config template has been updated.

[chouquette]

also just double checking, is it intended that the target branch is 7.50.x and not main?

[GustavoCaso]

I think it would be useful to split this PR into smaller more managable PR so the review process is not as dunting.

We could split the work into adding the agentless-scanner code and another PR with all the necessary changes to build a distribute the agentless-scanner and CI steps.

What do you think?

[GustavoCaso]

Also, I believe it would be good to add any entry in https://datadoghq.atlassian.net/wiki/spaces/agent/pages/3074132329/Overview+of+Agents+Binaries+and+shared+features with the overview of what the new binary does 😄

[0intro]

I think it would be useful to split this PR into smaller more managable PR so the review process is not as dunting.

We could split the work into adding the agentless-scanner code and another PR with all the necessary changes to build a distribute the agentless-scanner and CI steps.

What do you think?

Yes, I'll do that.

[0intro]

Also, I believe it would be good to add any entry in https://datadoghq.atlassian.net/wiki/spaces/agent/pages/3074132329/Overview+of+Agents+Binaries+and+shared+features with the overview of what the new binary does 😄

Interesting. I'll do that.

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 0243332b-afe0-4c86-8241-c7d86e596c41 Baseline: 155dc8cb0866c9949ba76d673eae913f4808f9dd Comparison: 6a0b6ab7ad0e3e890cd5aa1f05e16cffd4056bd1 Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI
❌	process_agent_standard_check_with_stats	memory utilization	+5.16	[+5.12, +5.21]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	idle	memory utilization	+3.45	[+3.42, +3.48]
➖	file_tree	memory utilization	+2.96	[+2.88, +3.04]
➖	file_to_blackhole	% cpu utilization	-0.24	[-6.77, +6.30]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
❌	process_agent_standard_check_with_stats	memory utilization	+5.16	[+5.12, +5.21]
➖	process_agent_real_time_mode	memory utilization	+4.05	[+4.01, +4.08]
➖	idle	memory utilization	+3.45	[+3.42, +3.48]
➖	process_agent_standard_check	memory utilization	+3.32	[+3.27, +3.37]
➖	file_tree	memory utilization	+2.96	[+2.88, +3.04]
➖	trace_agent_msgpack	ingress throughput	+0.06	[+0.05, +0.08]
➖	trace_agent_json	ingress throughput	+0.00	[-0.03, +0.03]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.03, +0.03]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.06, +0.06]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.04	[-0.11, +0.02]
➖	file_to_blackhole	% cpu utilization	-0.24	[-6.77, +6.30]
➖	otel_to_otel_logs	ingress throughput	-1.22	[-1.93, -0.50]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[0intro]

I've created a dedicated PR for the review of the datadog-agentless-scanner package.

https://github.com/DataDog/datadog-agent/pull/23097

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30644970 --os-family=ubuntu

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 8513f1ee-fe8f-4a9d-8429-cc6bd29c8466 Baseline: aa3dd973be0cdc8be3fc5be6346306d7587b0ad1 Comparison: c3a249032cbb2f6516c32ae759ad883ce4dc41f8

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+1.23	[-5.14, +7.61]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	basic_py_check	% cpu utilization	+2.95	[+0.23, +5.67]
➖	pycheck_1000_100byte_tags	% cpu utilization	+2.48	[-2.50, +7.46]
➖	file_to_blackhole	% cpu utilization	+1.23	[-5.14, +7.61]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.12	[-1.66, +3.90]
➖	process_agent_standard_check	memory utilization	+0.62	[+0.57, +0.67]
➖	tcp_syslog_to_blackhole	ingress throughput	+0.32	[+0.23, +0.40]
➖	idle	memory utilization	+0.28	[+0.24, +0.32]
➖	process_agent_standard_check_with_stats	memory utilization	+0.18	[+0.13, +0.23]
➖	otel_to_otel_logs	ingress throughput	+0.06	[-0.38, +0.49]
➖	trace_agent_msgpack	ingress throughput	+0.02	[+0.01, +0.03]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.20, +0.20]
➖	trace_agent_json	ingress throughput	-0.01	[-0.04, +0.03]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.02	[-0.05, +0.01]
➖	file_tree	memory utilization	-0.06	[-0.18, +0.05]
➖	process_agent_real_time_mode	memory utilization	-0.22	[-0.26, -0.18]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".