dasharo-issues icon indicating copy to clipboard operation
dasharo-issues copied to clipboard

Changing priority of `meta-dts-distro`

Open DaniilKl opened this issue 1 year ago • 5 comments

Dasharo version (if applicable)

Dasharo Tools Suite built on commit 386e4d402abd29661b88c76e0ef5bb6568766dac.

Dasharo variant (if applicable)

Affected component(s) or functionality (if applicable)

meta-dts-distro layer.

Brief summary

Considering changing meta-dts-distro priority to 11.

Additional context

  • Reason: DTS layers should have higher priority in the build, otherwise recipes from meta-dts-distro will be overwritten by other layers whenever it is possible and lead to errors or misunderstanding.
  • Example: on commit 386e4d402abd29661b88c76e0ef5bb6568766dac (which is latest develop branch) recipe hidapi_1.4.1.bb from meta-dts-distro is being overwritten during build by recipe hidapi_git.bb from meta-openembedded. This can be verified by checking workdir of the package hidapi after build:
λ ls build/tmp/work/core2-64-dts-linux/hidapi
0.11.2-r0

Which matches version from the recipe from meta-openembedded, which is:

λ cat ./meta-oe/recipes-support/hidapi/hidapi_git.bb
(...)
PV = "0.11.2"
(...)

DaniilKl avatar Mar 29 '24 14:03 DaniilKl

Found out about this during digging in issue https://github.com/Dasharo/dasharo-issues/issues/729.

DaniilKl avatar Mar 29 '24 14:03 DaniilKl

@TomaszAIR please review the idea in this issue

artur-rs avatar Apr 15 '24 12:04 artur-rs

why label invalid? Do we want to implement this, or not? If not, let’s simply close.

macpijan avatar Jun 28 '24 20:06 macpijan

@DaniilKl ping, question above

artur-rs avatar Jul 04 '24 12:07 artur-rs

why label invalid?

My bad.

Do we want to implement this, or not?

I still think we should implement this, but the team opinion was to live it the way it is.

DaniilKl avatar Jul 04 '24 12:07 DaniilKl

@DaniilKl can be closed? Priority was increased to 9 in: https://github.com/Dasharo/meta-dts/commit/2442ec338def833bb3d1382267fb6ad93d9ecf66

m-iwanicki avatar Sep 27 '24 14:09 m-iwanicki