coreboot util/txesbmantool: Add utility to generate TXE SB manifests

util/txesbmantool: Add utility to generate TXE SB manifests

Open miczyg1 opened this issue 1 year ago • 5 comments

Apr 17 '24 14:04 miczyg1

I still have to include it in Bay Trail makefiles to generate the manifests.

Apr 17 '24 14:04 miczyg1

Associated PR: https://github.com/Dasharo/dasharo-sdk/pull/4

Apr 17 '24 16:04 miczyg1

Tested on MinnowBoard Turbot dual core to boot with SBM and KM generated by this tool.

Apr 17 '24 16:04 miczyg1

Do we add some README? Do we push this tool to upstream?

Apr 17 '24 17:04 macpijan

Do we add some README?

I can add a brief one.

Do we push this tool to upstream?

We probably will upstream it along with the whole MinnowBaord Turbot board code and TXE Secure Boot support.

Apr 19 '24 09:04 miczyg1

Adding --help and --version options would be great here

Jun 11 '24 07:06 PLangowski

Adding --help and --version options would be great here

Added

Jun 13 '24 13:06 miczyg1

@krystian-hebel not waiting for checks to finish? :)

Jul 30 '24 10:07 miczyg1

They passed before the rebase, and rebase hasn't changed code added here. If the tests were to fail, they would have failed on previous attempts.

Jul 30 '24 10:07 krystian-hebel

@krystian-hebel now we have a failed job due to cancellation :)

Jul 30 '24 11:07 miczyg1

OK, note to self: don't trust that everybody takes care to not break main branch. It has been broken by https://github.com/Dasharo/coreboot/pull/543

Jul 30 '24 11:07 krystian-hebel

https://github.com/Dasharo/edk2/pull/157 was merged by GUI instead of CLI, so commit hash changed, and no longer matches the one in configs.

Jul 30 '24 11:07 krystian-hebel

It wasn't merged by GUI, it was rebased and then I fastforwarded the rebased branch. Should've remembered to check the commit hash, sorry

Jul 30 '24 12:07 mkopec