nxdumptool icon indicating copy to clipboard operation
nxdumptool copied to clipboard

Have colored text to indicate success or failure when dumping

Open ccfman2004 opened this issue 1 year ago • 4 comments

Is your feature request related to a problem? Please describe. With the text being so small on the screen I am having a hard time reading it and since the progress text is all white I find it difficult to see if a dump was successful or there was an error.

Describe the solution you'd like Change the text color of the finished message to either be green for success or red for error. This would make it much easier to see if the dump was all good or there was an error.

ccfman2004 avatar Jan 20 '24 21:01 ccfman2004

Great idea! I'm looking thru the code to see if I can implement this.

PolyCatDev avatar May 05 '24 16:05 PolyCatDev

ok. I think I found the part that prints out the output. It's at the bottom of data_transfer_progress_display.cpp

    std::string DataTransferProgressDisplay::GetFormattedSizeString(double size)
    {
        char strbuf[0x40] = {0};
        utilsGenerateFormattedSizeString(size, strbuf, sizeof(strbuf));
        return std::string(strbuf);
    }

I don't know enough about C++ right now to implement this

PolyCatDev avatar May 05 '24 16:05 PolyCatDev

@PolyCatDev I'd recommend against doing that, since I've been actively working on the borealis-based UI (and my own borealis fork) as of late. I won't accept any PRs to it for the time being.

This issue most likely refers to PoC builds, which do use console-based text output. Their logic is entirely located within nxdt_rw_poc.c. Feel free to take a look at it if you want.

DarkMatterCore avatar May 05 '24 16:05 DarkMatterCore

Aha, I see. Thx a lot for the clarification. I hoped it would be as easy as adding a few argumets to render the text a certain color but I was dead wrong.

PolyCatDev avatar May 05 '24 16:05 PolyCatDev