unleashed-firmware icon indicating copy to clipboard operation
unleashed-firmware copied to clipboard

feat[infrared]: allow disabling automatic signal decoding

Open darmiel opened this issue 2 years ago • 4 comments
trafficstars

What's new

Adds a new menu item Lean New Remote RAW in the Infrared App, which is only visible when the debug mode is enabled in the settings. When used, automatic decoding of signals is prevented -> you always get a raw capture.

https://user-images.githubusercontent.com/71837281/211199190-d4621c9a-4258-43e9-a181-a61327746d47.mov

Verification

  • Verify that debug mode is disabled (Settings -> System -> Debug -> OFF)
  • Open the Infrared app
  • Learn New Remote RAW should be missing
  • Verify that debug mode is enabled (Settings -> System -> Debug -> ON)
  • Open the Infrared app
  • Learn New Remote RAW should be available
  • Use Learn New Remote and verify that signals are decoded
  • Use Learn New Remote RAW and verify that signals are not decoded

Checklist (For Reviewer)

  • [x] PR has description of feature/bug
  • [x] Description contains actions to verify feature/bugfix
  • [ ] I've built this code, uploaded it to the device and verified feature/bugfix

darmiel avatar Jan 08 '23 13:01 darmiel

Fiya! 🔥

amec0e avatar Jan 11 '23 11:01 amec0e

Why bother hiding the option when Settings > System > Debug is off? You may as well always make it visible and have some consistency with the Sub Ghz app.

forid786 avatar Jan 13 '23 14:01 forid786

Why bother hiding the option when Settings > System > Debug is off? You may as well always make it visible and have some consistency with the Sub Ghz app.

No, it is not needed for regular usage, normal learn captures raw data if it cannot decode it This function forces it to disable decoding which is shouldn’t be available to regular users

hiding it in debug is a requirement to have that functionality

xMasterX avatar Jan 13 '23 15:01 xMasterX

Ah okay, yeah that makes sense. Completely forgot that it does automatically fall back to RAW when it cannot decode it.

forid786 avatar Jan 13 '23 15:01 forid786