unleashed-firmware icon indicating copy to clipboard operation
unleashed-firmware copied to clipboard

NFC-V support

Open TheKogoro opened this issue 3 years ago • 45 comments
trafficstars

Description of the feature you're suggesting.

Many NFC system using NVC-V keycard (ISO 15693) that isnt supported by flipper zero actually. NFC-V is main used by most of Skydata system (Parking lot, Ski station, and many other system...).

Actually, NFC-V is "readable" but cannot do nothing with it on flipper. It only showing a number without any possibility

Anything else?

No response

TheKogoro avatar Oct 13 '22 08:10 TheKogoro

That is due to limitation of NFC chipset used in flipper

nemanjan00 avatar Nov 22 '22 10:11 nemanjan00

That is due to limitation of NFC chipset used in flipper

That's not true. It's just not implemented on official firmware yet. See this pull request, someone already implemented a working draft with further NFC-V / ISO 15693 features: https://github.com/flipperdevices/flipperzero-firmware/pull/1991

vikwin avatar Dec 06 '22 17:12 vikwin

As I said, lib and chip is not designed for anything other than reading of NFC-V...

Anything else is usage of chip outside of spec and hack

nemanjan00 avatar Dec 12 '22 16:12 nemanjan00

I have to correct myself. Apparently, there is raw mode which can be used to interact with ISO15693 cards.

Thanks to @bettse for correcting me

nemanjan00 avatar Dec 13 '22 10:12 nemanjan00

I would LOVE to see the support for NFC-V Tags as soon as possible (In the official firmware) :)

flaneo avatar Jan 13 '23 23:01 flaneo

Awesome, thanks for your Work :D Make my day <3 Am 14. Jan. 2023, 11:06 +0100 schrieb Enteee @.***>:

well, there is this: flipperdevices/flipperzero-firmware#1991 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

FoxLy1312 avatar Jan 14 '23 14:01 FoxLy1312

PR is not draft anymore. It is pending review now

Maybe time to merge?

https://github.com/flipperdevices/flipperzero-firmware/pull/2316

nemanjan00 avatar Jan 19 '23 13:01 nemanjan00

PR is not draft anymore. It is pending review now

Maybe time to merge?

flipperdevices/flipperzero-firmware#2316

Merging is blocked on that PR, until it is merged it is not ready.

amec0e avatar Jan 19 '23 17:01 amec0e

You can ask the developer @g3gg0, this has been ready for a bit

RogueMaster avatar Jan 19 '23 17:01 RogueMaster

Assuming OFW don't want to make any additional changes

amec0e avatar Jan 19 '23 17:01 amec0e

In this case the code is not 100% clean as it still directly access rfal* functions from some other layer. And there are for sure also some other quirks which are not that great.

Flipper zero crew are taking things serious. They have set rules and seem to follow them, which is a good practice. So not having merged the PR already is absolutely okay and I am fine with that.

The underlying PulseReader/DigitalSequence PR was said to get merged soon, so I think I have reached the expected code quality for that part. And for the NfcV stuff I hope to get some feedback, but I think this will take until their NFC API rework goes live.

Thats the "does it follow my architecture" point of view.

From a "stability" point of view however, I consider the NfcV stuff stable enough for a merge. Haven't seen any crashes, hickups or nonfunc situations. It was also successfully used by some other dev as underlying layer for picopass emulation.

So you can decide if it matches your criteria.

In any case, I would really love to see other people joining the work on it and e.g. file PRs to improve the NfcV code. There was a question if I could add writing memory payload to another card, maybe add some other card types etc. And also the rfal or generally adoption to the new NFC API are things, help would be appreciated :)

Regards, g3gg0

g3gg0 avatar Jan 19 '23 20:01 g3gg0

You can ask the developer @g3gg0, this has been ready for a bit

We will wait for official team to review that changes Or if author wants to send copy of that PR to our repo directly we can do our basic review (we have no dedicated nfc developers) and merge it

xMasterX avatar Jan 19 '23 20:01 xMasterX

In this case the code is not 100% clean as it still directly access rfal* functions from some other layer. And there are for sure also some other quirks which are not that great.

Flipper zero crew are taking things serious. They have set rules and seem to follow them, which is a good practice. So not having merged the PR already is absolutely okay and I am fine with that.

The underlying PulseReader/DigitalSequence PR was said to get merged soon, so I think I have reached the expected code quality for that part. And for the NfcV stuff I hope to get some feedback, but I think this will take until their NFC API rework goes live.

Thats the "does it follow my architecture" point of view.

From a "stability" point of view however, I consider the NfcV stuff stable enough for a merge. Haven't seen any crashes, hickups or nonfunc situations. It was also successfully used by some other dev as underlying layer for picopass emulation.

So you can decide if it matches your criteria.

In any case, I would really love to see other people joining the work on it and e.g. file PRs to improve the NfcV code. There was a question if I could add writing memory payload to another card, maybe add some other card types etc. And also the rfal or generally adoption to the new NFC API are things, help would be appreciated :)

Regards, g3gg0

Yes, you are right, but sometimes reviews from official team takes longer than expected So if possible can you make a duplicate of that PR but to us direclty? if not possible do you agree if I merge it by committing it manually, but a bit later

xMasterX avatar Jan 19 '23 20:01 xMasterX

Oh, thanks for that offer. Right now I am working on so many topics, be it flipper related (https://github.com/flipperdevices/flipperzero-firmware/pull/2311) or some other stuff (http://g3gg0.de) or even daily life, that I tend to get lost somewhere inbetween. Opening another PR here would most likely cause a cerebral stack overflow.

I hope thats okay for you :)

g3gg0 avatar Jan 19 '23 20:01 g3gg0

Oh, thanks for that offer. Right now I am working on so many topics, be it flipper related (flipperdevices/flipperzero-firmware#2311) or some other stuff (http://g3gg0.de) or even daily life, that I tend to get lost somewhere inbetween. Opening another PR here would most likely cause a cerebral stack overflow.

I hope thats okay for you :)

Sure, I understand I think for now better solution will be to wait official team review, also im seeing that other users found issues and you fixed them already

xMasterX avatar Jan 20 '23 15:01 xMasterX

I also See on discord that NFC-V (Proprietary) will surely never work with flipper zero (Skidata for example) 🤔

TheKogoro avatar Jan 21 '23 19:01 TheKogoro

I also See on discord that NFC-V (Proprietary) will surely never work with flipper zero (Skidata for example) 🤔

can you explain that?

g3gg0 avatar Jan 21 '23 20:01 g3gg0

I also See on discord that NFC-V (Proprietary) will surely never work with flipper zero (Skidata for example) 🤔

can you explain that?

Yeah, i have ask If Skidata keycard (NFC-V) Iso15693 will be working with flipper zero and it seem to be Not possible without the datasheet or key. But i am Not an expert so i dont know really what is needed and somes other people say it never be possible.

If having physically the card can help to Make it working i can Always sens it one.

TheKogoro avatar Jan 21 '23 20:01 TheKogoro

if you aren't an expert, then please correct your statement as it is simply incorrect.

NfcV is possible and working. Even emulating is working. e.g. NXP SLIX* cards can already be emulated.

Regarding skidata, I have no clue what the reader is doing, but the latest PR adds a sniff feature. One could sniff the stuff the reader is sending to figure out what is happening. If you have any reliable information source, please link it.

g3gg0 avatar Jan 21 '23 20:01 g3gg0

if you aren't an expert, then please correct your statement as it is simply incorrect.

NfcV is possible and working. Even emulating is working. e.g. NXP SLIX* cards can already be emulated.

Regarding skidata, I have no clue what the reader is doing, but the latest PR adds a sniff feature. One could sniff the stuff the reader is sending to figure out what is happening. If you have any reliable information source, please link it.

I know i am Not an expert but is What people answering me that isnt be possible on official flipper zero discord under NFC Chanel. (Thanks for correct that by telling me this 👍🏻)

For the Sniffing feature, is with the "detect Reader" function ? If is that, the nfc coder of Skidata detect Flipper zero (as non useable card) but flipper zero doesnt detect the Skidata coder station.

Also sorry for misunderstand and bad Spelling, i Speak french and in english + technical speaking is relatively hard ^^

TheKogoro avatar Jan 21 '23 20:01 TheKogoro

This would require you to manually compile and flash the branch of my pull request.

g3gg0 avatar Jan 21 '23 20:01 g3gg0

@g3gg0 thanks for the work! I was testing it a bit from using the rougemaster release. It reads/saves the NXP-SLIX2 card well however emulation not working. My iphone NFC reader app is not detecting it but it recognizes the original card well.

update: ok... out of dozens of tries, 3 times fully worked, 3 times it says connection error.

ranqizhu avatar Feb 24 '23 18:02 ranqizhu

yeah same here. when reading using a phone, the reception quality is quite bad. not sure why, but even with a scope i can see that the pulses are incorrect sometimes. this makes me suspicious regarding the antenna tunings for the NFC chip or the transparent mode of that chip.

with a proxmark or a toniebox however the range for the flipper is comparable to a nfc sticker

g3gg0 avatar Feb 24 '23 19:02 g3gg0

Bonjour, Est-il juste possible de la cloner (copier et coller sur une autre)? Si oui, grace à quel Update? Merci par avance ;-)

M3NVU5 avatar Feb 27 '23 08:02 M3NVU5

french is not the most universal language in the world. please use english.

g3gg0 avatar Feb 27 '23 09:02 g3gg0

le français n'est pas la langue la plus universelle au monde. veuillez utiliser l'anglais.

Good morning, Is it just possible to clone it (copy and paste on another)? If so, which update? Thanks in advance ;-)

M3NVU5 avatar Feb 27 '23 09:02 M3NVU5

you cannot just copy NfcV cards. there are however "magic cards" which allow UID modification. you can however, depending on the exact type, emulate it on flipper.

g3gg0 avatar Feb 27 '23 12:02 g3gg0

just tried this using the rougemaster release, good job @g3gg0! Tested with ISO15693, SLIX and SLIX-L and worked like a charm!

Desko21 avatar Mar 07 '23 07:03 Desko21

just tried this using the rougemaster release, good job @g3gg0! Tested with ISO15693, SLIX and SLIX-L and worked like a charm!

I hope it will be soon in Unleashed too 🙏🏻

TheKogoro avatar Mar 08 '23 07:03 TheKogoro

Hello @g3gg0

I tested reading an NFC-V card via unleashed and the flipper was only able to give me the UID.

By testing your NFC-V reader module via RogueMaster, I got a lot more information and was able to emulate the card too!

Unfortunately, the reader does not react by offering him the emulator card from the FZ.

I therefore wonder about the emulation which seems incorrect. I have to try to copy the FZ card to a real SLI/SLIX UID card that can be found here: https://lab401.com/fr/products/icode-sli-slix-compatible-uid-modifiable?_pos=10&_sid=0a2e4b59f&_ss=r

If you want to take a look at the copy of the NFC-V card (copy-nfc-v-iso15963.nfc) with which I tested it is available here: https://file.io/AeR1zNkIFpis

Thank you for advancing the reading of NFC-V

Misstmourt avatar May 03 '23 13:05 Misstmourt