Yoopta-Editor icon indicating copy to clipboard operation
Yoopta-Editor copied to clipboard

[BUG] When clicking on a link is not going to the link

Open Lfrancos opened this issue 1 year ago • 4 comments

Has this bug been raised before?

  • [X] I have checked "open" AND "closed" issues and this is not a duplicate

Description

You can see that there are a lot of links in the preview but I'm not able to click to go to the link.

Steps to Reproduce

If you know the steps, follow the below format and provide steps to reproduce

For example:

  1. Go to the example page. 2 scroll down
  2. When you see "Do you like it? Please star our repo in Github.
  3. You should be able to click on "Our repo in Github". But I'm not able to.

Environment

  • Windows 11:
  • Browser: Chrome

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

Lfrancos avatar May 07 '24 11:05 Lfrancos

Good example, I actually had the same question. So, the editor shows you a way to change the link with the Link menu, but the link element is rendered without the ability to click it and follow the link.

image

maZahaca avatar May 07 '24 12:05 maZahaca

I would like to work on it

Nitin6404 avatar May 07 '24 12:05 Nitin6404

@Nitin6404 Here is the dev community, feel free to join and get in touch with us.

maZahaca avatar May 07 '24 13:05 maZahaca

Thanks for reporting! This is good point. Links are working good when editor is read only, but it should work for edit mode also. This is how I see the solution to this problem with a good approach to UX:

  1. When you hover over link in edit mode, something like a small button should be displayed over it Screen Shot 2024-05-07 at 16 36 41

  2. So, when you click on edit it should show Link editor from @yoopta/link-tool package Screen Shot 2024-05-07 at 16 39 47

  3. To access to Link editor from @yoopta/link-tool package (if it passed to props tools) we can use useTools hook

@Nitin6404 It would be great! Currently we are working on documentation for contribution. Join to our community - https://t.me/YooptaEditor

Darginec05 avatar May 07 '24 13:05 Darginec05

Done in @v4.6.4 https://github.com/user-attachments/assets/d6f21270-0ba6-4477-95fc-3099ca98deb7

Darginec05 avatar Jul 16 '24 17:07 Darginec05