ghc-mod icon indicating copy to clipboard operation
ghc-mod copied to clipboard

Published 20 hours ago • verified publisher icon DanielG

enable syntax check on save in literate haskell mode

Open kiripon opened this issue 11 years ago • 8 comments

kiripon avatar Oct 07 '14 09:10 kiripon

In my environment, when emacs is in literate-haskell-mode, syntax checks doesn't work on saving a file. I think this small fix will activate ghc-chck-syntax in literate-haskell-mode. Could you pull it?

kiripon avatar Oct 12 '14 07:10 kiripon

Any reason you closed this request? I was just holding off merging it until I come around to looking at the elisp stuff again, which I had to postpone because university is keeping me busy.

DanielG avatar Nov 04 '14 11:11 DanielG

@kazu-yamamoto do we still need this PR?

DanielG avatar Aug 20 '15 00:08 DanielG

I think we can accept this pull request if @kiripon wishes.

kazu-yamamoto avatar Aug 20 '15 01:08 kazu-yamamoto

Well I'm more asking does it look like it's going to break something ;)

DanielG avatar Aug 20 '15 01:08 DanielG

I don't think that this breaks something.

kazu-yamamoto avatar Aug 20 '15 01:08 kazu-yamamoto

Just curious. Is there any reason to use defadvice instead of after-save-hook?

iquiw avatar Aug 20 '15 03:08 iquiw

No. I did not hit upon after-save-hook when I implemented it.

BTW, now #550 is implemented. So, we don't have to save the buffer at all anymore. Should we provide a new key-binding to check syntax?

kazu-yamamoto avatar Aug 20 '15 03:08 kazu-yamamoto