reactphysics3d icon indicating copy to clipboard operation
reactphysics3d copied to clipboard

Add explicit include of chrone header.

Open robertocapuano opened this issue 6 months ago • 1 comments

Visual Studio Code doesn't find chrono namespace: include is needed

robertocapuano avatar May 04 '25 11:05 robertocapuano

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.19%. Comparing base (7000610) to head (583fabe). Report is 7 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #421   +/-   ##
========================================
  Coverage    56.19%   56.19%           
========================================
  Files          182      182           
  Lines        13872    13872           
  Branches      1173     1173           
========================================
  Hits          7796     7796           
  Misses        6076     6076           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar May 04 '25 11:05 codecov-commenter

I confirm having the same problem on my Github actions workflow. I am building with

  • CMake
  • Ninja generator
  • msvc compiler
C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\cl.exe  /nologo /TP  -ID:build\windows-msvc-debug\_deps\reactphysics3d-src\include /DWIN32 /D_WINDOWS /EHsc /Ob0 /Od /RTC1 -std:c++20 -MDd -Zi /showIncludes @_deps\reactphysics3d-build\CMakeFiles\reactphysics3d.dir\src\body\Body.cpp.obj.modmap /Fo_deps\reactphysics3d-build\CMakeFiles\reactphysics3d.dir\src\body\Body.cpp.obj /Fd_deps\reactphysics3d-build\CMakeFiles\reactphysics3d.dir\reactphysics3d.pdb /FS -c D:\build\windows-msvc-debug\_deps\reactphysics3d-src\src\body\Body.cpp
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(129): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(129): error C2039: 'now': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(129): error C3536: 'now': cannot be used before it is initialized
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(130): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(130): error C2039: 'to_time_t': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(130): error C3861: 'to_time_t': identifier not found
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(187): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(187): error C2039: 'now': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(187): error C3536: 'now': cannot be used before it is initialized
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(188): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(188): error C2039: 'to_time_t': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(188): error C3861: 'to_time_t': identifier not found

robinwils avatar Jun 29 '25 14:06 robinwils