reactphysics3d icon indicating copy to clipboard operation
reactphysics3d copied to clipboard

Warning on c++20 build (emscripten)

Open caxapexac opened this issue 3 years ago • 2 comments
trafficstars

In file included from include/reactphysics3d/reactphysics3d.h:42:
In file included from include\reactphysics3d/engine/PhysicsCommon.h:31:
In file included from include\reactphysics3d/engine/PhysicsWorld.h:45:
include\reactphysics3d/collision/OverlapCallback.h:99:30: warning: explicitly defaulted copy assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
                OverlapPair& operator=(const OverlapPair& contactPair) = default;
                             ^
include\reactphysics3d/collision/OverlapCallback.h:78:30: note: copy assignment operator of 'OverlapPair' is implicitly deleted because field 'mContactPair' is of reference type 'reactphysics3d::ContactPair &'
                ContactPair& mContactPair;

I can provide any additional info which could help to locate this warning build configuration, is it needed?

caxapexac avatar Aug 26 '22 16:08 caxapexac

Thanks for reporting this. I will try to fix this in the next release.

DanielChappuis avatar Aug 30 '22 13:08 DanielChappuis

Oh huge thanks for such a speed :)

caxapexac avatar Sep 05 '22 02:09 caxapexac

This is now fixed in version v0.10.0 of the library. Thanks a lot for reporting the issue.

DanielChappuis avatar Mar 10 '24 13:03 DanielChappuis

@DanielChappuis thanks for the fix. Btw several days ago I've tried to update myself to the develop branch of the engine because of https://github.com/DanielChappuis/reactphysics3d/issues/366 But ended up making those iterator changes manually instead of updating (updating to 'develop' caused another different crash to happen). I'll create the issue on a new crash as soon as I get some time (it didn't crash on a current release, something on a broad phase probably iirc, when I forcefully change the translation of an object while it has a contactpair with another object)

caxapexac avatar Mar 10 '24 13:03 caxapexac

@caxapexac Yes, if you could open a new issue with a stack trace, it would be great.

DanielChappuis avatar Mar 10 '24 13:03 DanielChappuis