reactphysics3d
reactphysics3d copied to clipboard
Add move semantics to vector classes
Codecov Report
Merging #127 into master will increase coverage by
0.07%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 63.29% 63.36% +0.07%
==========================================
Files 120 120
Lines 5882 5877 -5
==========================================
+ Hits 3723 3724 +1
+ Misses 2159 2153 -6
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/mathematics/Vector2.h | 100% <ø> (ø) |
:arrow_up: |
| src/mathematics/Vector3.h | 95.45% <ø> (+3.39%) |
:arrow_up: |
| src/collision/MiddlePhaseTriangleCallback.h | 0% <0%> (-100%) |
:arrow_down: |
| src/collision/CollisionDetection.h | 85.71% <0%> (-14.29%) |
:arrow_down: |
| src/collision/HalfEdgeStructure.h | 95.23% <0%> (-4.77%) |
:arrow_down: |
| src/collision/shapes/CapsuleShape.cpp | 88.49% <0%> (-0.11%) |
:arrow_down: |
| src/collision/narrowphase/GJK/VoronoiSimplex.h | 100% <0%> (ø) |
:arrow_up: |
| src/collision/ProxyShape.h | 100% <0%> (ø) |
:arrow_up: |
| src/mathematics/Transform.h | 100% <0%> (ø) |
:arrow_up: |
| ... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update f9fa2a2...0948a33. Read the comment docs.
Why not add the default specifiers inline with the member function declaration?
Thanks a lot for your pull request. However, in the current code, there is no more copy-constructors and therefore the Vector2 and Vector3 classes have implicit move operators. Therefore this pull request is no more needed but again, thanks a lot.