angular-tour icon indicating copy to clipboard operation
angular-tour copied to clipboard

Adding Optional Second button and function

Open CaptainJeff opened this issue 10 years ago • 4 comments

This fork lets you add an optional button next to the "Next" button. This lets you call a function on a specific button which lets the tour be more interactive

CaptainJeff avatar Jul 30 '15 20:07 CaptainJeff

Hi @CaptainJeff - This sounds like a potentially good feature, but I'll need a couple of things from you before I can look at it further. Looks like you modified one of the dynamically built amalgamations rather than the upstream source (/src/tour/tour.js). You can edit that file and then run npm install && grunt to run tests and rebuild the dist files. Also, it would be nice if you could rebase your commits, squashing them into a single commit.

Thanks and let me know if you have any questions.

booleanbetrayal avatar Aug 05 '15 00:08 booleanbetrayal

Will do man, didn't realize I should be changing that /src/tour/tour.js file. I also changed quite a bit. I added a few optional features. Some would call functions, others would just be a href, and there were some styling features. I'll re-do this and submit again. It'll probably take me a few days or a week.

CaptainJeff avatar Aug 05 '15 02:08 CaptainJeff

Sounds good! If you have multiple independent features you'd like to get in, it'd make more sense to do individual PRs. You can always keep a private fork and cherry-pick individual commits as needed to support your project in the meantime.

booleanbetrayal avatar Aug 07 '15 14:08 booleanbetrayal

Hey @CaptainJeff - Just seeing if you would like to clean up this PR (or file a new one). Thanks!

booleanbetrayal avatar Nov 10 '15 15:11 booleanbetrayal