Racci

Results 72 comments of Racci
trafficstars

Opening early as a draft. Initial changes are working and have tests added for them just need to figure out how we are going to implement a timeout value, if...

Was wanting to get some feedback on this before progressing further, is this the correct place to implement the timeout logic? @extrawurst

Also worth mentioning as its done in this PR, I've changed the test shell shebang to use `/usr/bin/env sh` as this is a more widely accepted and allows distributions like...

I've also noticed that while running tests that since i use the non POSIX Shell (nushell) that i need to prefix the command with SHELL=bash, i was wondering if it...

Now that the implementation is solid how do i go about with setting the timeout, how do we expose configurable value for the user and should there be a default...

@Byron I've updated the implementation and it is now inside git2-hooks, I've added new functions with suffixed `_with_timeout` for each hook but the `run_hooks` function has a breaking change having...

The last remaining thing to do is move the tests i had written over to the git2_hooks crate, even so the current tests in asyncgit should be able to cover...

I was also thinking about the initial issue where the problem was an infinite wait because the hook was waiting for input, maybe a solution could be when a hook...

I'll get some tests put into the git2-hooks crate and resolve these issue when I get some times on the weekend to do so, please let me know if there...

> The idea would be to leave the `run_hooks()` function alone, and have it call the `_with_timeout()` function internally with a zero-timeout. That way one trivially avoids the breaking change...