domjudge icon indicating copy to clipboard operation
domjudge copied to clipboard

Link from card on contests overview page to single contest page

Open vmcj opened this issue 1 year ago • 6 comments
trafficstars

The issue suggested using the header only but that felt a bit hard for people to find the link so the whole card is used now. The buttons in the card still work with their own links.

Fixes: #2462

<a href={{ path('jury_contest', {'contestId': contest.cid}) }}>

Is the only interesting piece, the rest is fixing indentation.

vmcj avatar Jul 25 '24 19:07 vmcj

Shouldn't we only link from the card header instead of the whole card?

nickygerritsen avatar Jul 26 '24 06:07 nickygerritsen

Shouldn't we only link from the card header instead of the whole card?

See my first message, I found that hard to find and I don't see the problem with making the whole card clickable. Do we want a button to attract attention as alternative?

vmcj avatar Jul 26 '24 13:07 vmcj

I find it a bit strange that you can now click for example on the checkmark to open the contest, but that might just be me.

nickygerritsen avatar Jul 26 '24 13:07 nickygerritsen

I find it a bit strange that you can now click for example on the checkmark to open the contest, but that might just be me.

Ok, do you want a button as alternative? I think it will be hard for people to find the feature if it only works with the header and I rather not have extra buttons. I do agree that clicking on the checkbox is a little strange. Let's see what the rest thinks.

vmcj avatar Jul 26 '24 17:07 vmcj

What about adding a link to the header with <i class="fa-solid fa-pen"></i> as icon?

meisterT avatar Aug 03 '24 10:08 meisterT

What about adding a link to the header with <i class="fa-solid fa-pen"></i> as icon?

I would consider that a button, but I'll change the PR with that change.

vmcj avatar Aug 03 '24 10:08 vmcj

image

I associate pen with editing so went with another icon but anything from https://fontawesome.com/search?o=r&m=free should be fine.

vmcj avatar Sep 12 '24 15:09 vmcj