domjudge
domjudge copied to clipboard
Link from card on contests overview page to single contest page
The issue suggested using the header only but that felt a bit hard for people to find the link so the whole card is used now. The buttons in the card still work with their own links.
Fixes: #2462
<a href={{ path('jury_contest', {'contestId': contest.cid}) }}>
Is the only interesting piece, the rest is fixing indentation.
Shouldn't we only link from the card header instead of the whole card?
Shouldn't we only link from the card header instead of the whole card?
See my first message, I found that hard to find and I don't see the problem with making the whole card clickable. Do we want a button to attract attention as alternative?
I find it a bit strange that you can now click for example on the checkmark to open the contest, but that might just be me.
I find it a bit strange that you can now click for example on the checkmark to open the contest, but that might just be me.
Ok, do you want a button as alternative? I think it will be hard for people to find the feature if it only works with the header and I rather not have extra buttons. I do agree that clicking on the checkbox is a little strange. Let's see what the rest thinks.
What about adding a link to the header with <i class="fa-solid fa-pen"></i> as icon?
What about adding a link to the header with
<i class="fa-solid fa-pen"></i>as icon?
I would consider that a button, but I'll change the PR with that change.
I associate pen with editing so went with another icon but anything from https://fontawesome.com/search?o=r&m=free should be fine.