terraform-aws-ecs icon indicating copy to clipboard operation
terraform-aws-ecs copied to clipboard

Remove all `terraform=true` hardcoded tags

Open lucasmacedot opened this issue 10 months ago • 2 comments

Terraform errors if the default_tags block have the same tag as the tags on a resource. A better way to manage this is to put all tags on the default_tags block, and pass tags specific to modules on the tags variable

image

Types of changes

What types of changes does your code introduce to <repo_name>? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] I have read the CONTRIBUTING.md doc.
  • [ ] I have added necessary documentation (if appropriate).
  • [ ] Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

lucasmacedot avatar Jan 05 '25 21:01 lucasmacedot