online-judge icon indicating copy to clipboard operation
online-judge copied to clipboard

Add warning when posting code to comments

Open int-y1 opened this issue 1 year ago • 3 comments
trafficstars

cleaned-up version of https://github.com/VNOI-Admin/OJ/pull/201

Screenshot 2024-05-27 231527

int-y1 avatar May 28 '24 06:05 int-y1

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.78%. Comparing base (fd7fb05) to head (c3d0cab). Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
+ Coverage   46.76%   46.78%   +0.01%     
==========================================
  Files         251      252       +1     
  Lines       13317    13348      +31     
==========================================
+ Hits         6228     6245      +17     
- Misses       7089     7103      +14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 28 '24 06:05 codecov-commenter

I think this code is also used for contest / blog post comments. Maybe we want a different message there since redirecting to the "submit solution" button is no longer meaningful.

Ninjaclasher avatar May 28 '24 06:05 Ninjaclasher

list of changes:

  • popup message changed. "post a source code" -> "post some source code"
  • popup only appears on /problem/<problem code>. all other comment sections still work, and aren't affected.

int-y1 avatar Jun 05 '24 04:06 int-y1