DIRAC icon indicating copy to clipboard operation
DIRAC copied to clipboard

[8.0] Add PreferredURLPattern for URL sorting

Open chrisburr opened this issue 9 months ago • 4 comments

See the included docs for motivation.

BEGINRELEASENOTES

*Configuration NEW: Add PreferredURLPattern for URL sorting

ENDRELEASENOTES

chrisburr avatar Feb 28 '25 12:02 chrisburr

Looks good to me but I let somebody from another VO have a look, because it may be of interest to them (maybe @iueda @hmiyake , as they have services scattered around the globe ? )

chaen avatar Mar 03 '25 09:03 chaen

That's interesting. We are categorizing our servers to some groups (e.g. having UPS or not), then sometimes modify URLs to change active servers.

For such operation I prefer to change single value than list, since error proofing.

Let me gather comments to the PR from our colleagues.

hmiyake avatar Mar 03 '25 10:03 hmiyake

At the moment this is on a per system basis, though maybe it would make sense to move globally for all URLs? Thoughts?

That's interesting. We are categorizing our servers to some groups (e.g. having UPS or not), then sometimes modify URLs to change active servers.

If it would be useful I could support a list of regexes, i.e.

    PreferredURLPatterns = .*\.preferred\.invalid/.*
    PreferredURLPatterns += .*\.secondary\.invalid/.*
    PreferredURLPatterns += .*\.tertiary\.invalid/.*

@hmiyake What would you prefer?

chrisburr avatar Mar 03 '25 10:03 chrisburr

I wanted to ask the global option! For my user case, it completely matches.

A list of regexes are also helpful to give priority... I like both!

hmiyake avatar Mar 06 '25 09:03 hmiyake

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/15140420840

Failed:

  • integration cherry-pick 2e4317e76 into integration failed check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-2e4317e76-integration
    git cherry-pick -x -m 1 2e4317e76
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #8065 Add PreferredURLPatterns for URL sorting' --author='Chris Burr <[email protected]>'
    git push -u origin cherry-pick-2-2e4317e76-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] Add PreferredURLPatterns for URL sorting' \
         --body 'Sweep #8065 `Add PreferredURLPatterns for URL sorting` to `integration`.
    
    Adding original author @chrisburr as watcher.
    
    BEGINRELEASENOTES
    
    *Configuration
    NEW: Add PreferredURLPattern for URL sorting
    
    ENDRELEASENOTES
    Closes #8201'
    

DIRACGridBot avatar May 20 '25 14:05 DIRACGridBot