remix-redis-session icon indicating copy to clipboard operation
remix-redis-session copied to clipboard

Published 20 hours ago • verified publisher icon DAlperin

Wrap secondsDelta in a Math.round

Open yadyn opened this issue 2 years ago • 1 comments

Ensure that secondsDelta is an integer so that Redis is happy.

Fixes #5

yadyn avatar Nov 28 '22 20:11 yadyn

Hi @DAlperin , just came around to this package, could we merge this PR?

The issue it's fixing is pretty quick to reproduce (just spam refresh when committing the session with new content).

I'll just patch-package for now, but hopefully this is a super quick one to review :)

Floating point strikes again!

micotodev avatar May 05 '23 18:05 micotodev

Question for the ones involved. Where do i actually set the expires of the session? In all my cases in redis it ends up as -1.

EDIT: Found it but notice this update is not pushed yet?

pimjansen avatar May 15 '24 14:05 pimjansen

We are currently encountering the issue fixed by this MR as well.

@DAlperin Could you tell us if there is a planned release anytime soon please ? Thank you in advance.

Kagaminara avatar Jul 29 '24 13:07 Kagaminara