go-sqlmock
go-sqlmock copied to clipboard
Wrong condition to check Begin options
trafficstars
There is a bug on this line https://github.com/DATA-DOG/go-sqlmock/blob/master/sqlmock.go#L256
if expected.txOpts != nil &&
expected.txOpts.Isolation != opts.Isolation &&
expected.txOpts.ReadOnly != opts.ReadOnly {
return nil, fmt.Errorf("expected transaction options do not match: %+v, got: %+v", expected.txOpts, opts)
}
but should be:
if expected.txOpts != nil &&
(expected.txOpts.Isolation != opts.Isolation || expected.txOpts.ReadOnly != opts.ReadOnly) {
return nil, fmt.Errorf("expected transaction options do not match: %+v, got: %+v", expected.txOpts, opts)
}
@ninadingole please check