dao-contracts icon indicating copy to clipboard operation
dao-contracts copied to clipboard

Allow voting up to expiration time

Open nlipartiia-hacken opened this issue 3 years ago • 3 comments

Closes #463.

nlipartiia-hacken avatar Sep 02 '22 16:09 nlipartiia-hacken

hey! thanks for putting this together! skimmed this and it looks good. we're really busy trying to get v2 released here so might be a couple days before i can get to a proper review. <3

0xekez avatar Sep 02 '22 23:09 0xekez

apologies for the delay in reviewing here -- lets push this through! Also, for the integration test failure, rebasing on main should fix it.

blue-note avatar Sep 19 '22 20:09 blue-note

thanks for the review! I rebased over main, hope it fixes the failure

nlipartiia-hacken avatar Sep 20 '22 21:09 nlipartiia-hacken

closing this for now. @NinoLipartiia if you have plans for picking this up feel free to just push to this branch and we'll reopen and do more review :) just want to clear the pr queue.

0xekez avatar Nov 17 '22 21:11 0xekez

I'll pick this up

bekauz avatar Nov 17 '22 22:11 bekauz