jupyterlab-sql-editor icon indicating copy to clipboard operation
jupyterlab-sql-editor copied to clipboard

JupyterLab 4 compatibility question

Open yogevyuval opened this issue 2 years ago • 11 comments

Hi, Is jupyterlab-sql-editor compatible and check with JupyterLab version 4 and jupyterlab-lsp version 5.0.0? Asking because i'm getting erros activating the plugins with the new versions.

@cccs-nik Thanks

yogevyuval avatar Oct 24 '23 20:10 yogevyuval

It's indeed not compatible yet, it hopefully should be soon.

cccs-nik avatar Oct 30 '23 15:10 cccs-nik

It's indeed not compatible yet, it hopefully should be soon.

Thanks @cccs-nik that;'s good to hear, will keep track of the repo

yogevyuval avatar Oct 31 '23 17:10 yogevyuval

@cccs-nik Checking in if you think you have some thoughts on when do you think you will look into JupyterLab 4.0? Or specifiicaly if you know what will be the major changes, and how complicated the transition might be.

Today we are using JupyterLab 4.0, but jupyterlab-sql-editor is a perfect fit for some of our needs and we are really keen of using it

yogevyuval avatar Dec 06 '23 17:12 yogevyuval

Hey @yogevyuval, I got a local branch going last week but it's not building yet. I'm working on it whenever I get a chance and I'm hoping the transition isn't too complicated 🙂

cccs-nik avatar Dec 11 '23 15:12 cccs-nik

Hi again @yogevyuval. I pushed an alpha release for JupyterLab 4.0 support: https://pypi.org/project/jupyterlab-sql-editor/1.0.0a1/. It's not quite ready yet, notably the syntax highlighting is broken but the rest should hopefully be working fine enough. I'll get back to finishing the upgrade in 2024 🙂

cccs-nik avatar Dec 21 '23 22:12 cccs-nik

Hi again @yogevyuval. I pushed an alpha release for JupyterLab 4.0 support: https://pypi.org/project/jupyterlab-sql-editor/1.0.0a1/. It's not quite ready yet, notably the syntax highlighting is broken but the rest should hopefully be working fine enough. I'll get back to finishing the upgrade in 2024 🙂

That's great progress! appreciate your work on this, looking forward for the syntax highlighting in 2024!

Happy holidays :)

yogevyuval avatar Dec 21 '23 22:12 yogevyuval

@cccs-nik I see progress is being made - that's really cool! appreciate it.

One question regarding this - We are very excited to use this for our own usage, but we are going to need different markers (instead of relying on --start-spraksql we want to rely on a different string.) Do you think it would somehow be possible in the new version to support this customization? Thanks

yogevyuval avatar Jan 09 '24 16:01 yogevyuval

Hey @yogevyuval! Yeah I think that should be simple enough to implement.

cccs-nik avatar Jan 15 '24 15:01 cccs-nik

Hey @yogevyuval! Yeah I think that should be simple enough to implement.

@cccs-nik oh that's great to hear! should I start using the current branch or are you expecting to create a more official release soon?

Btw - i'm up to chat (slack / teams etc') if you youd like some specific feedback or help.

yogevyuval avatar Jan 18 '24 13:01 yogevyuval

@yogevyuval Keep using the branch for now, we're not quite ready for JupyterLab 4 so I'll be supporting JupyterLab 3 for now if anything comes up and merging the fixes to the JupyterLab 4 branch. We unfortunately don't have a public facing communications channel yet so if you want to chat it would maybe be on something like a big public Slack channel. Let me know 🙂

cccs-nik avatar Jan 30 '24 16:01 cccs-nik

@yogevyuval Keep using the branch for now, we're not quite ready for JupyterLab 4 so I'll be supporting JupyterLab 3 for now if anything comes up and merging the fixes to the JupyterLab 4 branch. We unfortunately don't have a public facing communications channel yet so if you want to chat it would maybe be on something like a big public Slack channel. Let me know 🙂

@cccs-nik Great, can you add me to any slack / other platform you already have? if so I will send you my email address. Otherwise, we can try adding you to our slack, we just going to need your email

let me know what do you prefer :)

yogevyuval avatar Feb 13 '24 17:02 yogevyuval