MCDSaveEdit icon indicating copy to clipboard operation
MCDSaveEdit copied to clipboard

Armor features not loading

Open kurai01 opened this issue 3 years ago • 4 comments

Having an odd problem while using using MCDSaveEdit 1.5.2.0 and the Steam version of MCD 1.13.1.0, related to armor. If I either change an existing piece or add a new piece of armor, it does not load the armor's appropriate feature-set. For newly added armor, the features are completely missing and I'd have to manually add them myself. If I replace a piece of existing armor the old armor's features remain and are transferred to the newly selected version.

I've previously used the 1.4.2 version and do not recall having this issue at the time, so this seems new to 1.5.2. I can't check because 1.4.2 reports that it cannot decrypt the pak file at the standard Steam location: C:\Program Files (x86)\Steam\steamapps\common\MinecraftDungeons\Dungeons\Content\Paks

The 1.5.2 app doesn't complain when launching and pointing at that location, so I'm assuming it is able to decrypt the pak files, but perhaps it is having trouble with the armor files?

kurai01 avatar Mar 20 '22 18:03 kurai01

Are you talking about selecting an enchantment for a weapon/armour? If so the same thing is happening to me. I click the Enchantment icon, and I can see that the window opens, but when trying to select it I get kicked back to the main window.

Existing enchantments I can select and upgrade as expected though.

Edit: It seems to eventually appear after resizing the window a few times I think. I'm not sure what fixed it though. I think the idea is that the window is supposed to appear next to the primary window, and if that is too large/maximised then it doesn't behave?

TreeBranches avatar Mar 24 '22 10:03 TreeBranches

I am referring to the armor features, like the weapon damage aura on Mercenary Armor. If I have that armor in my inventory, it loads fine when I select it. However, if I either add a new piece or swap an existing armor to a new type, none of that new armor’s characteristics load. It thought it might be a visual bug, but it loads that way in the game too.

kurai01 avatar Mar 24 '22 13:03 kurai01

For newly added armor, the features are completely missing and I'd have to manually add them myself

This is actually intended behavior of MCDSaveEdit. I cannot find in the pak files where it defines what armor properties belong on each of the different armors, probably because they want some of them to have randomizations to them. So, if you want an armor with the expected properties you will have to look it up on a wiki page somewhere (I don't have the time to keep something like that updated).

I think the idea is that the window is supposed to appear next to the primary window

Yes, that was the idea. I didn't think anyone would run MCDSaveEdit in fullscreen. I will have to make some code changes to handle that. Thanks for finding a bug!

CutFlame avatar Mar 30 '22 07:03 CutFlame

Yes, that was the idea. I didn't think anyone would run MCDSaveEdit in fullscreen. I will have to make some code changes to handle that. Thanks for finding a bug!

I discovered it initially because my laptop screen is 3:2, so even though it wasn't maximised it still didn't fit next to it.

Now that I know about it it's less of an issue!

TreeBranches avatar Mar 30 '22 13:03 TreeBranches