RedditSharp-DEPRECATED- icon indicating copy to clipboard operation
RedditSharp-DEPRECATED- copied to clipboard

Remove support for ModHashes and cookie auth

Open CrustyJew opened this issue 8 years ago • 5 comments

Unless someone can give some compelling reasons to keep the legacy stuff in, I'm starting to remove support for relying on ModHashes as it will help clean up some code and they aren't necessary with OAuth.

One of the main complaints about OAuth was that it was harder to use with bots, now that there is an implementation BotWebAgent which handles token expiration for you, I don't think this should be a major issue any more.

CrustyJew avatar May 02 '17 13:05 CrustyJew

Kill it with fire.

pimanac avatar May 02 '17 14:05 pimanac

If done, it would probably be best to provide links to or provide proper documentation for the proper usage in the README.

james7132 avatar May 02 '17 17:05 james7132

Well, the legacy stuff still works until reddit decides to retire it, so why remove perfectly valid functionality?

chuggafan avatar May 02 '17 20:05 chuggafan

The issue is mostly support and having to maintain both versions. It's not really worth it to try and bend code to work with a past implementation that has been deprecated forever and who knows when it will finally be removed. The replacement has been simplified enough that there isn't any good reason that I can see to still use the old methods.

CrustyJew avatar May 04 '17 01:05 CrustyJew

#85 related merge

CrustyJew avatar May 05 '17 00:05 CrustyJew