CrowdTruth-core icon indicating copy to clipboard operation
CrowdTruth-core copied to clipboard

Fix metrics.run to work with pandas >= 1.1.0

Open Lowess opened this issue 4 years ago • 2 comments

@ancadumitrache This PR is a small fix to solve some issues we ran into while using pandas >= 1.1.0 it's been tested with pandas == 1.2.4 and we got the same results as before.

Please consider this PR for a main stream merge and release !

Thanks

Lowess avatar Apr 13 '21 06:04 Lowess

Codecov Report

Merging #5 (747c1c8) into master (f1a494b) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   92.04%   92.11%   +0.07%     
==========================================
  Files           8        9       +1     
  Lines         553      558       +5     
==========================================
+ Hits          509      514       +5     
  Misses         44       44              
Impacted Files Coverage Δ
crowdtruth/models/metrics.py 99.26% <100.00%> (+<0.01%) :arrow_up:
crowdtruth/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1a494b...747c1c8. Read the comment docs.

codecov-io avatar Apr 13 '21 06:04 codecov-io

@oana-inel @Bouncer FYI

Lowess avatar Apr 13 '21 21:04 Lowess

+1 on this PR. I had to apply this change to get it working.

cyriltw avatar Sep 05 '23 16:09 cyriltw