git-code-format-maven-plugin icon indicating copy to clipboard operation
git-code-format-maven-plugin copied to clipboard

Plugin can produce empty commits and committed files show up as modified in git status

Open pfeileon opened this issue 2 years ago • 2 comments

What steps will reproduce the problem?

  1. Make changes to a file's formatting which conflict with google-code-formatter.
  2. Commit the changes.

Expected

  • There should be no commit as there are no changes after the formatter fixed the files in the pre-commit hook.
  • git status should report a clean state.

Actual

  • An empty commit was produced.
  • git status reports the file as modified, git diff reports no changes, however.

The part with the modified files without changes showing up also happens after a "real" commit. git add . cleans it up again.

Environment: git-code-format-maven-plugin 4.2 Apache Maven 3.8.6 Java version: 11.0.14 (Red Hat) Windows 10 git version 2.38.0.windows.1

pfeileon avatar Jan 13 '23 12:01 pfeileon