angularx-qrcode icon indicating copy to clipboard operation
angularx-qrcode copied to clipboard

feat: Update to Angular v18

Open moh4sa opened this issue 1 year ago • 8 comments

Upgrade the packages to the latest version of Angular. close #251

moh4sa avatar May 30 '24 06:05 moh4sa

@Cordobo for your review

moh4sa avatar May 31 '24 10:05 moh4sa

Any progress on this? Will really appreciate it for my ng 18 project :)

Arthi93 avatar Jun 04 '24 16:06 Arthi93

What's poppin', don't mind me just watchin' 👀 😆

kyjus25 avatar Jun 10 '24 15:06 kyjus25

Really looking forward to this upgrade

lvetskov avatar Jun 11 '24 07:06 lvetskov

@Cordobo this is pending your review

moh4sa avatar Jun 15 '24 12:06 moh4sa

Can we please check this @Cordobo ? This is the only dependency I have I cant upgrade to angular 18.

alexookah avatar Jun 17 '24 10:06 alexookah

Any progress on this? really appreciate it if can be fast track this. Thanks.

ghost avatar Jun 19 '24 05:06 ghost

Just in case you need to urgently update, you may want temporarily add this to package.json while waiting image

JustroX avatar Jun 19 '24 05:06 JustroX

Angular 18 is two months old now, rather not force a dependency override. Please merge this :)

xanather avatar Jul 05 '24 03:07 xanather

@Cordobo We'd really appreciate it if you could merge this sooner. This is a great library and it's the only one holding us back from updating to v18.

behdi avatar Jul 12 '24 11:07 behdi

@Cordobo Do you have an estimated timeline for when this will be merged? This is the only package we are waiting on to complete our migration to Angular 18.

A-ahmadisalem avatar Jul 17 '24 07:07 A-ahmadisalem

I think its time to decide:

  1. Maintainer adds more other maintainers with write access
  2. Fork this
  3. Use a different package

xanather avatar Jul 17 '24 12:07 xanather

Are there any other packages?

caboodal avatar Jul 19 '24 19:07 caboodal

@everyone I think this would be a good replacement for anyone who still waiting for this PR like me https://github.com/mnahkies/ng-qrcode#readme

moh4sa avatar Jul 22 '24 10:07 moh4sa

A merge would help us too!

maxmayr95 avatar Jul 24 '24 16:07 maxmayr95

I'm going to look at switching to the other component tomorrow. I'll report back my findings.

caboodal avatar Jul 24 '24 17:07 caboodal

@caboodal why not just use the fix? The one with overriding angular core version? Works good for me. Tested today

maxmayr95 avatar Jul 24 '24 18:07 maxmayr95

@maxmayr95 we are using the fix but I don't want a dependency in our apps that's not being maintained. Angular versions are coming thick and fast the next one we might not be so lucky.

caboodal avatar Jul 24 '24 18:07 caboodal