Coordinator metrics - blob and finalization submissions

[bradbown]

trafficstars

This PR implements issue(s) #

Implements the metrics:

• highest blob submitted to l1
• highest accepted blob on l1
• highest submitted finalisation on l1
• highest accepted finalisation on l1
• blob submission delay
• finalisation submission delay

Example of the histrogram metric for recording the delays (Y axis is in seconds):

Checklist

• [ ] I wrote new tests for my new core changes.
• [ ] I have successfully ran tests, style checker and build against my new changes locally.
• [ ] I have informed the team of any breaking changes if there are any.

[github-actions[bot]]

Delta Summary - Kotlin Code Coverage

Generated on:	09/26/2024 - 14:33
Description	Previous	Current	Delta
Coverage date:	09/26/2024 - 14:33	09/26/2024 - 14:33
Tag:	479_11054195980	479_11054195980
Line coverage:	27.5%	27.5%	0.0%
Covered lines:	25973	25973	0
Coverable lines:	94427	94427	0
Total lines:	134237	134237	0
Branch coverage:	10.5%	10.5%	0.0%
Covered branches:	5591	5591	0
Total branches:	53028	53028	0
Method coverage:	Feature is only available for sponsors

[jpnovais]

@bradbown sorry for the conflicts, can you please merge main?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 43.01075% with 106 lines in your changes missing coverage. Please review.

Project coverage is 71.23%. Comparing base (2f37b73) to head (59d42b6).

Files with missing lines	Patch %	Lines
.../consensys/zkevm/coordinator/app/L1DependentApp.kt	0.00%	61 Missing :warning:
...n/kotlin/net/consensys/zkevm/domain/Aggregation.kt	32.00%	17 Missing :warning:
...src/main/kotlin/net/consensys/zkevm/domain/Blob.kt	31.81%	15 Missing :warning:
...nsys/zkevm/ethereum/coordination/MaxLongTracker.kt	0.00%	7 Missing :warning:
...otlin/net/consensys/linea/metrics/MetricsFacade.kt	0.00%	2 Missing :warning:
...inea/metrics/micrometer/MicrometerMetricsFacade.kt	88.88%	0 Missing and 2 partials :warning:
...finalization/AggregationFinalizationCoordinator.kt	50.00%	1 Missing :warning:
...kevm/ethereum/finalization/AggregationSubmitter.kt	91.66%	1 Missing :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               main      #97      +/-   ##
============================================
- Coverage     71.53%   71.23%   -0.31%     
- Complexity     1085     1091       +6     
============================================
  Files           299      301       +2     
  Lines         12148    12288     +140     
  Branches       1084     1148      +64     
============================================
+ Hits           8690     8753      +63     
- Misses         2968     3043      +75     
- Partials        490      492       +2     

Flag	Coverage Δ		*Carryforward flag
hardhat	98.63% <ø> (-0.05%)	:arrow_down:	Carriedforward from 16f5d6c
kotlin	69.12% <43.01%> (-0.22%)	:arrow_down:

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...sys/zkevm/ethereum/coordination/EventDispatcher.kt	100.00% <100.00%> (ø)
...m/ethereum/submission/BlobSubmissionCoordinator.kt	86.36% <100.00%> (+2.27%)	:arrow_up:
...ission/BlobSubmitterAsEIP4844MultipleBlobsPerTx.kt	89.70% <100.00%> (+10.39%)	:arrow_up:
...ission/L1ShnarfBasedAlreadySubmittedBlobsFilter.kt	90.00% <100.00%> (-4.45%)	:arrow_down:
...a/metrics/micrometer/MicrometerHistogramAdapter.kt	100.00% <100.00%> (ø)
...finalization/AggregationFinalizationCoordinator.kt	72.95% <50.00%> (+1.75%)	:arrow_up:
...kevm/ethereum/finalization/AggregationSubmitter.kt	77.94% <91.66%> (+1.15%)	:arrow_up:
...otlin/net/consensys/linea/metrics/MetricsFacade.kt	85.71% <0.00%> (-14.29%)	:arrow_down:
...inea/metrics/micrometer/MicrometerMetricsFacade.kt	91.48% <88.88%> (-1.62%)	:arrow_down:
...nsys/zkevm/ethereum/coordination/MaxLongTracker.kt	19.23% <0.00%> (-5.77%)	:arrow_down:
... and 3 more

... and 7 files with indirect coverage changes

[bradbown]

@bradbown sorry for the conflicts, can you please merge main?

@jpnovais All merged