linea-monorepo icon indicating copy to clipboard operation
linea-monorepo copied to clipboard

fix: add binary constraints for accumulators first lines

Open ivokub opened this issue 1 year ago • 1 comments
trafficstars

This PR fixes LA audit report Issue I.

In the ECPair module we have a column indicating if the current limb is the first line of the current or previous accumulator. As this is natively a boolean condition then we need to enforce it as a constraint to ensure the soundness in case of malicious prover.

Depends on #172. That one needs to be merged first and then the base branch of this one update to main.

Checklist

  • [ ] I wrote new tests for my new core changes.
  • [x] I have successfully ran tests, style checker and build against my new changes locally.
  • [x] I have informed the team of any breaking changes if there are any.

ivokub avatar Oct 10 '24 10:10 ivokub

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.38%. Comparing base (9763bf2) to head (b330294).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #173   +/-   ##
=========================================
  Coverage     70.38%   70.38%           
  Complexity     1040     1040           
=========================================
  Files           282      282           
  Lines         11314    11314           
  Branches       1030     1030           
=========================================
  Hits           7963     7963           
  Misses         2880     2880           
  Partials        471      471           
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 67.86% <ø> (ø) Carriedforward from 9763bf2

*This pull request uses carry forward flags. Click here to find out more.

codecov-commenter avatar Oct 10 '24 10:10 codecov-commenter