linea-monorepo
linea-monorepo copied to clipboard
fix: ensure IsActive column does not re-activate
This PR fixes Issue H in the LA audit report.
For the precompile glue modules we have the IsActive column indicating if the current row is actual computation row or padding to ensure that the column is padded up to power of two length. When the rows are padding rows then we expect that the rest of the columns are zero in the same row.
This PR enforces that the IsActive column can not go from 0 to 1 (deactivated->activated), causing possible soundness issues. Furthermore, started using the common_constraints package for better modularity.
Checklist
- [ ] I wrote new tests for my new core changes.
- [x] I have successfully ran tests, style checker and build against my new changes locally.
- [x] I have informed the team of any breaking changes if there are any.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.39%. Comparing base (
215b60c) to head (a458249).
Additional details and impacted files
@@ Coverage Diff @@
## main #172 +/- ##
============================================
+ Coverage 70.38% 70.39% +0.01%
Complexity 1040 1040
============================================
Files 282 282
Lines 11314 11312 -2
Branches 1082 1082
============================================
Hits 7963 7963
- Misses 2880 2882 +2
+ Partials 471 467 -4
| Flag | Coverage Δ | *Carryforward flag | |
|---|---|---|---|
| hardhat | 98.70% <ø> (ø) |
||
| kotlin | 67.87% <ø> (+0.01%) |
:arrow_up: | Carriedforward from e1b956c |
*This pull request uses carry forward flags. Click here to find out more.