linea-monorepo
linea-monorepo copied to clipboard
fixed newHash assignment
This PR fixes the bug in the padding module. On the prover side, the NewHash Column should be assigned based on the index column. When the index becomes zero a newHash is launched. In the previous implementation, NewHash was assigned via HashNum which was not correct. Due to the required change, some testes are not passing since they have empty or incorrect indexes. these tests are also fixed.
Checklist
- [ ] I wrote new tests for my new core changes.
- [ ] I have successfully ran tests, style checker and build against my new changes locally.
- [ ] I have informed the team of any breaking changes if there are any.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.36%. Comparing base (
8f67c1e) to head (304171b). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #161 +/- ##
=========================================
Coverage 70.36% 70.36%
Complexity 1040 1040
=========================================
Files 282 282
Lines 11316 11316
Branches 1083 1031 -52
=========================================
Hits 7963 7963
Misses 2886 2886
Partials 467 467
| Flag | Coverage Δ | *Carryforward flag | |
|---|---|---|---|
| hardhat | 98.70% <ø> (ø) |
||
| kotlin | 67.84% <ø> (ø) |
Carriedforward from a68e65b |
*This pull request uses carry forward flags. Click here to find out more.