linea-monorepo
linea-monorepo copied to clipboard
fixed the bug in the permutation
This PR addresses an issue in the permutation-query. for the multi-column cases, the Z polynomial nominator and dominator were both built based on the same polynomial A (rather than A against B). Causing the verifier to accept false claims over multi-column cases.
More test cases are added to cover the false claims that we don't expect the verifier to accept.
Checklist
- [ ] I wrote new tests for my new core changes.
- [ ] I have successfully ran tests, style checker and build against my new changes locally.
- [ ] I have informed the team of any breaking changes if there are any.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.38%. Comparing base (
c186d66) to head (329fdd4). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #155 +/- ##
=========================================
Coverage 70.38% 70.38%
Complexity 1040 1040
=========================================
Files 282 282
Lines 11314 11314
Branches 1082 1082
=========================================
Hits 7963 7963
Misses 2880 2880
Partials 471 471
| Flag | Coverage Δ | |
|---|---|---|
| hardhat | 98.70% <ø> (ø) |
|
| kotlin | 67.86% <ø> (ø) |