linea-monorepo icon indicating copy to clipboard operation
linea-monorepo copied to clipboard

fix revert in accordance with comments

Open Tabaie opened this issue 1 year ago • 2 comments

As per auditor feedback https://consensys.slack.com/archives/C07771UFHUG/p1725977141736399, even if unreachable, the code section should match its comments and reset.

Tabaie avatar Sep 27 '24 17:09 Tabaie

Delta Summary - Kotlin Code Coverage

Generated on: 09/27/2024 - 17:36
Description Previous Current Delta
Coverage date: 09/27/2024 - 17:36 09/27/2024 - 17:36
Tag: 530_11075084174 530_11075084174
Line coverage: 27.3% 27.3% 0.0%
Covered lines: 25673 25673 0
Coverable lines: 93723 93723 0
Total lines: 132974 132974 0
Branch coverage: 10.4% 10.4% 0.0%
Covered branches: 5529 5529 0
Total branches: 52680 52680 0
Method coverage: Feature is only available for sponsors

github-actions[bot] avatar Sep 27 '24 17:09 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.54%. Comparing base (f53e2d1) to head (5b36c0f).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #114   +/-   ##
=========================================
  Coverage     70.54%   70.54%           
  Complexity     1042     1042           
=========================================
  Files           282      282           
  Lines         11310    11310           
  Branches       1028     1080   +52     
=========================================
  Hits           7979     7979           
  Misses         2861     2861           
  Partials        470      470           
Flag Coverage Δ
hardhat 98.69% <ø> (ø)
kotlin 68.05% <ø> (ø)

codecov-commenter avatar Sep 27 '24 17:09 codecov-commenter