linea-monorepo icon indicating copy to clipboard operation
linea-monorepo copied to clipboard

3822 rejected transaction api service

Open jonesho opened this issue 1 year ago • 2 comments
trafficstars

This PR implements issue(s) #

Checklist

  • [ ] I wrote new tests for my new core changes.
  • [ ] I have successfully ran tests, style checker and build against my new changes locally.
  • [ ] I have informed the team of any breaking changes if there are any.

jonesho avatar Sep 25 '24 16:09 jonesho

Delta Summary - Kotlin Code Coverage

Generated on: 10/03/2024 - 08:37
Description Previous Current Delta
Coverage date: 10/03/2024 - 08:37 10/03/2024 - 08:37
Tag: 651_11157913743 651_11157913743
Line coverage: 27.1% 27.1% 0.0%
Covered lines: 25877 25877 0
Coverable lines: 95371 95371 0
Total lines: 136038 136038 0
Branch coverage: 10.4% 10.4% 0.0%
Covered branches: 5566 5566 0
Total branches: 53031 53031 0
Method coverage: Feature is only available for sponsors

github-actions[bot] avatar Sep 25 '24 16:09 github-actions[bot]

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.73%. Comparing base (303e581) to head (69af199).

Files with missing lines Patch % Lines
...lin/net/consensys/zkevm/persistence/db/DbHelper.kt 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #101      +/-   ##
============================================
- Coverage     70.57%   68.73%   -1.84%     
- Complexity     1059     1072      +13     
============================================
  Files           291      257      -34     
  Lines         11960    11062     -898     
  Branches       1103      893     -210     
============================================
- Hits           8441     7604     -837     
+ Misses         3039     2978      -61     
  Partials        480      480              
Flag Coverage Δ
hardhat ?
kotlin 68.73% <95.23%> (+0.47%) :arrow_up:
Files with missing lines Coverage Δ
...in/kotlin/net/consensys/zkevm/persistence/db/Db.kt 100.00% <100.00%> (ø)
...nsensys/zkevm/persistence/db/PersistenceRetryer.kt 100.00% <100.00%> (ø)
...ys/zkevm/persistence/db/PostgresHelperFunctions.kt 100.00% <ø> (ø)
...t/consensys/zkevm/persistence/db/SQLQueryLogger.kt 40.00% <ø> (ø)
...otlin/net/consensys/linea/metrics/MetricsFacade.kt 100.00% <100.00%> (ø)
...lin/net/consensys/zkevm/persistence/db/DbHelper.kt 55.26% <0.00%> (ø)

... and 40 files with indirect coverage changes

codecov-commenter avatar Sep 26 '24 05:09 codecov-commenter

@jpnovais updated after rebased on latest main, pls help review again, especially the integration test, thx!

jonesho avatar Oct 17 '24 19:10 jonesho