linea-attestation-registry icon indicating copy to clipboard operation
linea-attestation-registry copied to clipboard

feat(explorer): As an end-user, I want to get more straight-forward information out of the issuer details page

Open satyajeetkolhapure opened this issue 1 year ago • 2 comments
trafficstars

What does this PR do?

This PR is in draft. It contains below changes on the Issuer page:

  • new banner
  • Attestation count
  • Schema and Portal combination card
  • links

Changes remaining:

  1. The current Attestations page is changed to allow a 'where' clause in the query parameter, although the total counter shown for the pagination is always the total number of attestations. It needs to change to show Attestation counter for where clause. There is no easy way showing it, unless we add a new field at the subgraph level. The counter is available for Portals but not for the combination of Portal and Schema. It needs to be implemented in a generic and easy way.

  2. Logos with dark and light theme need to be revisited for the new page.

  3. The data file has hardcoded Issuer's Portal + Schema combinations. Those needs to be updated with correct data.

Related ticket

Fixes #679

Type of change

  • [ ] Chore
  • [ ] Bug fix
  • [x] New feature
  • [ ] Documentation update

Check list

  • [ ] Unit tests for any smart contract change
  • [ ] Contracts and functions are documented

satyajeetkolhapure avatar Jul 30 '24 09:07 satyajeetkolhapure

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.07%. Comparing base (b26f79c) to head (f3e7c7f).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #672   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          30       30           
  Lines         492      492           
  Branches      112      112           
=======================================
  Hits          453      453           
  Misses         39       39           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 13 '24 14:08 codecov-commenter

🚀 Deployed on https://66d07521845bc51735d3bae9--resilient-starburst-d5d6d9.netlify.app

github-actions[bot] avatar Aug 13 '24 14:08 github-actions[bot]